Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Replace "Manage in settings" with "No thanks" in the STX Opt In modal, only show the modal for non-zero balances #25848

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Jul 16, 2024

Description

This PR has 2 updates for the STX Opt In modal:

  • Replaces "Manage in settings" with "No thanks" in the STX Opt In modal
  • Only shows the modal for non-zero balances

TODOs:

  • Add tests for the getIsSmartTransactionsOptInModalAvailable function

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

No STX Opt In modal if there is 0 balance:

  1. Install the extension from scratch, create a new wallet
  2. After getting to the extension's homepage, there will be no STX Opt In modal

STX Opt In modal if balance > 0:

  1. Install the extension from scratch, import a wallet that has some ETH on Ethereum mainnet
  2. After getting to the extension's homepage, you will see the modal

Screenshots/Recordings

image

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 requested a review from a team as a code owner July 16, 2024 07:17
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 added the team-transactions Transactions team label Jul 16, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [39b9e0d]
Page Load Metrics (324 ± 302 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint612991045125
domContentLoaded95524157
load382047324630302
domInteractive95524157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -334 Bytes (-0.00%)
  • common: 196 Bytes (0.00%)

@dan437 dan437 force-pushed the stx-opt-in-updates branch from 39b9e0d to 29b4470 Compare July 16, 2024 16:31
Copy link

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dan437 dan437 merged commit d02f647 into develop Jul 17, 2024
75 of 77 checks passed
@dan437 dan437 deleted the stx-opt-in-updates branch July 17, 2024 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [29b4470]
Page Load Metrics (89 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint653891216933
domContentLoaded9101382311
load49289895627
domInteractive9100382311
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: -355 Bytes (-0.00%)
  • common: 30 Bytes (0.00%)

@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants