Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jl/caip multichain/lifecycle methods #25842

Merged
merged 9 commits into from
Jul 17, 2024

Conversation

jiexi
Copy link
Contributor

@jiexi jiexi commented Jul 15, 2024

Description

  • Add wallet_getSession
  • Add wallet_revokeSession
  • Emit wallet_sessionChanged on authorization change
    • Note this does not include specs. Seems we are not currently testing accountChanged and chainChanged events and should probably get those covered first

Open in GitHub Codespaces

Related issues

See: https://github.com/MetaMask/MetaMask-planning/issues/2821

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helpers added in this file can probably be DRY'ed

Comment on lines +5610 to +5611
// TODO: Uncomment this when wallet lifecycle methods are added to api-specs
// engine.push(multichainMethodCallValidatorMiddleware);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. And blazing fast 😮

@jiexi jiexi marked this pull request as ready for review July 17, 2024 17:08
@jiexi jiexi requested a review from a team as a code owner July 17, 2024 17:08
@jiexi jiexi merged commit c9c03ad into caip-multichain Jul 17, 2024
63 of 69 checks passed
@jiexi jiexi deleted the jl/caip-multichain/lifecycle-methods branch July 17, 2024 17:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants