remove methods from multichain API #25841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
commented
Jul 15, 2024
| { origin }, | ||
| { eth_accounts: {} }, | ||
| ), | ||
| requestPermittedChainsPermission: (chainIds) => |
There was a problem hiding this comment.
dang seems like we can't remove this one yet either
jiexi
reviewed
Jul 15, 2024
| // to our permissioning logic in the JSON-RPC middleware pipeline. | ||
| export const createMethodMiddleware = makeMethodMiddlewareMaker(allHandlers); | ||
| export const createLegacyMethodMiddleware = |
There was a problem hiding this comment.
thoughts on something like this? Legacy already means something already, so doing this increases potential confusion
Suggested change
| export const createLegacyMethodMiddleware = | |
| export const createEip1193MethodMiddleware = |
There was a problem hiding this comment.
Yeah I considered this as well. Yeah we could go with this.
jiexi
approved these changes
Jul 15, 2024
adonesky1
force-pushed
the
ad/remove-non-multichain-methods-from-multichain-api
branch
from
40bd03b to
cd2a9a9
Compare
adonesky1
force-pushed
the
ad/remove-non-multichain-methods-from-multichain-api
branch
from
cd2a9a9 to
e2c1f68
Compare
adonesky1
deleted the
ad/remove-non-multichain-methods-from-multichain-api
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist