fix: edit path to dist folder #25826

zone-live · 2024-07-15T09:29:13Z

Description

Fixes some path issues that prevented the extension from being found.

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-07-15T09:29:29Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-07-15T09:57:27Z

Builds ready [7a5d738]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (68 ± 8 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	75	143	97	17	8
		domContentLoaded	10	57	30	16	8
		load	46	110	68	17	8
		domInteractive	10	57	30	16	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-07-15T11:41:00Z

Builds ready [3091c2e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (365 ± 328 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	74	467	144	118	57
		domContentLoaded	9	165	41	40	19
		load	44	2198	365	683	328
		domInteractive	9	165	41	40	19

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-07-15T13:08:48Z

Builds ready [b3883c8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (353 ± 312 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	355	123	56	27
		domContentLoaded	10	74	36	18	9
		load	48	2020	353	650	312
		domInteractive	10	74	36	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

davibroc

LGTM

metamaskbot · 2024-07-15T14:46:48Z

Builds ready [c88a555]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (147 ± 182 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	123	89	16	8
		domContentLoaded	9	62	22	12	6
		load	42	1799	147	379	182
		domInteractive	9	62	22	12	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-07-15T14:49:19Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

codecov · 2024-07-15T15:08:35Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (a8639a2) to head (35f5e00).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25826   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1394     1394           
  Lines        48945    48945           
  Branches     13467    13467           
========================================
  Hits         34250    34250           
  Misses       14695    14695

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-07-15T15:18:58Z

Builds ready [35f5e00]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (75 ± 18 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	400	107	69	33
		domContentLoaded	9	104	33	21	10
		load	40	218	75	37	18
		domInteractive	9	104	33	21	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

fix: edit path to dist folder

7a5d738

zone-live added the team-mmi PRs from the MMI team label Jul 15, 2024

fix: typo in path and snapshot update

3091c2e

zone-live marked this pull request as ready for review July 15, 2024 11:39

zone-live requested a review from a team as a code owner July 15, 2024 11:39

zone-live requested review from albertolive and davibroc July 15, 2024 11:40

albertolive previously approved these changes Jul 15, 2024

View reviewed changes

Added back ImportTokens after dev fix

b3883c8

davibroc dismissed albertolive’s stale review via b3883c8 July 15, 2024 12:38

fix: skip for now

7a2f452

davibroc previously approved these changes Jul 15, 2024

View reviewed changes

fix: lint fix

9cb8fb7

zone-live dismissed davibroc’s stale review via 9cb8fb7 July 15, 2024 13:35

Merge branch 'develop' into MMI-5253-pw-e2e-test-not-running

c88a555

davibroc previously approved these changes Jul 15, 2024

View reviewed changes

shane-t self-requested a review July 15, 2024 14:40

shane-t previously approved these changes Jul 15, 2024

View reviewed changes

Bumped timeout

35f5e00

davibroc dismissed stale reviews from shane-t and themself via 35f5e00 July 15, 2024 14:47

davibroc approved these changes Jul 15, 2024

View reviewed changes

albertolive approved these changes Jul 15, 2024

View reviewed changes

NidhiKJha approved these changes Jul 15, 2024

View reviewed changes

zone-live merged commit c3bff60 into develop Jul 15, 2024
78 of 79 checks passed

zone-live deleted the MMI-5253-pw-e2e-test-not-running branch July 15, 2024 15:15

github-actions bot locked and limited conversation to collaborators Jul 15, 2024

metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: edit path to dist folder #25826

fix: edit path to dist folder #25826

zone-live commented Jul 15, 2024 •

edited

Loading

github-actions bot commented Jul 15, 2024

metamaskbot commented Jul 15, 2024

metamaskbot commented Jul 15, 2024

metamaskbot commented Jul 15, 2024

davibroc left a comment

metamaskbot commented Jul 15, 2024

sonarqubecloud bot commented Jul 15, 2024

codecov bot commented Jul 15, 2024

metamaskbot commented Jul 15, 2024

fix: edit path to dist folder #25826

fix: edit path to dist folder #25826

Conversation

zone-live commented Jul 15, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jul 15, 2024

metamaskbot commented Jul 15, 2024

metamaskbot commented Jul 15, 2024

metamaskbot commented Jul 15, 2024

davibroc left a comment

Choose a reason for hiding this comment

metamaskbot commented Jul 15, 2024

sonarqubecloud bot commented Jul 15, 2024

Quality Gate passed

codecov bot commented Jul 15, 2024

Codecov Report

metamaskbot commented Jul 15, 2024

zone-live commented Jul 15, 2024 •

edited

Loading