Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removed unused getCustodianAccountsByAddress method #25798

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Jul 12, 2024

Description

We currently have the getCustodianAccountsByAddress being passed in:

ui/store/institutional/institution-background.ts

But it doesn’t seem to be of any use.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@albertolive albertolive added the team-mmi PRs from the MMI team label Jul 12, 2024
@albertolive albertolive requested a review from a team as a code owner July 12, 2024 12:38
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [c424f7d]
Page Load Metrics (65 ± 9 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6313693199
domContentLoaded96026168
load4010865189
domInteractive96026168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@albertolive albertolive merged commit c0e42da into develop Jul 12, 2024
71 of 73 checks passed
@albertolive albertolive deleted the MMI-5206-remove-unused-method branch July 12, 2024 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
@metamaskbot metamaskbot added the release-12.3.0 Issue or pull request that will be included in release 12.3.0 label Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants