Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Code cleanup on quoted attributes #25783

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ui/components/app/alert-system/alert-modal/alert-modal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ function AlertDetails({
{t('alertModalDetails')}
</Text>
) : null}
<Box as="ul" className={'alert-modal__alert-details'} paddingLeft={6}>
<Box as="ul" className="alert-modal__alert-details" paddingLeft={6}>
{selectedAlert.alertDetails?.map((detail, index) => (
<Box as="li" key={`${selectedAlert.key}-detail-${index}`}>
<Text variant={TextVariant.bodyMd}>{detail}</Text>
Expand Down Expand Up @@ -213,11 +213,11 @@ export function AcknowledgeCheckboxBase({
>
<Checkbox
label={label ?? t('alertModalAcknowledge')}
data-testid={'alert-modal-acknowledge-checkbox'}
data-testid="alert-modal-acknowledge-checkbox"
isChecked={isConfirmed}
onChange={onCheckboxClick}
alignItems={AlignItems.flexStart}
className={'alert-modal__acknowledge-checkbox'}
className="alert-modal__acknowledge-checkbox"
/>
</Box>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ function ConfirmDetails({
onClick={onAlertLinkClick}
target="_blank"
rel="noopener noreferrer"
data-testid={'confirm-alert-modal-review-all-alerts'}
data-testid="confirm-alert-modal-review-all-alerts"
>
<Icon
name={IconName.SecuritySearch}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ function AlertDetails({
<Box marginTop={1}>
<Disclosure title={t('seeDetails')} variant={DisclosureVariant.Arrow}>
{details instanceof Array ? (
<Box as="ul" className={'alert-modal__alert-details'} paddingLeft={6}>
<Box as="ul" className="alert-modal__alert-details" paddingLeft={6}>
{details.map((detail, index) => (
<Box as="li" key={`disclosure-detail-${index}`}>
<Text
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function PreviousButton({
ariaLabel={t('back')}
size={ButtonIconSize.Sm}
onClick={onBackButtonClick}
className={'confirm_nav__left_btn'}
className="confirm_nav__left_btn"
data-testid="alert-modal-back-button"
borderRadius={BorderRadius.full}
color={IconColor.iconAlternative}
Expand Down Expand Up @@ -81,7 +81,7 @@ function NextButton({
ariaLabel={t('next')}
size={ButtonIconSize.Sm}
onClick={onNextButtonClick}
className={'confirm_nav__right_btn'}
className="confirm_nav__right_btn"
data-testid="alert-modal-next-button"
borderRadius={BorderRadius.full}
color={IconColor.iconAlternative}
Expand Down
2 changes: 1 addition & 1 deletion ui/components/multichain/toast/toast.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export const Toast = ({
<Box display={Display.Flex} gap={4} data-testid={dataTestId}>
{startAdornment}
<Box>
<Text className={'toast-text'} variant={textVariant}>
<Text className="toast-text" variant={textVariant}>
{text}
</Text>
{actionText && onActionClick ? (
Expand Down
6 changes: 3 additions & 3 deletions ui/pages/confirmations/components/confirm/header/header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ const Header = ({
className="confirm_header__wrapper"
alignItems={AlignItems.center}
justifyContent={JustifyContent.spaceBetween}
data-testid={'confirm-header'}
data-testid="confirm-header"
>
<Box alignItems={AlignItems.flexStart} display={Display.Flex} padding={4}>
<Box display={Display.Flex} marginTop={2}>
Expand All @@ -52,13 +52,13 @@ const Header = ({
<Text
color={TextColor.textDefault}
variant={TextVariant.bodyMdMedium}
data-testid={'header-account-name'}
data-testid="header-account-name"
>
{fromName}
</Text>
<Text
color={TextColor.textAlternative}
data-testid={'header-network-display-name'}
data-testid="header-network-display-name"
>
{networkDisplayName}
</Text>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const ScrollToBottom = ({ children, showAdvancedDetails }: ContentProps) => {

{isScrollable && !isScrolledToBottom && (
<ButtonIcon
className={'confirm-scroll-to-bottom__button'}
className="confirm-scroll-to-bottom__button"
onClick={scrollToBottom}
iconName={IconName.Arrow2Down}
ariaLabel={t('scrollDown')}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ function ConfirmBannerAlert({ ownerId }: { ownerId: string }) {
return (
<Box marginTop={4}>
<GeneralAlert
data-testid={'confirm-banner-alert'}
data-testid="confirm-banner-alert"
title={
hasMultipleAlerts
? t('alertBannerMultipleAlertsTitle')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ type RedirectUrlIconProps = {
const RedirectUrlIcon = ({ url, onSubmit }: RedirectUrlIconProps) => {
return (
<ButtonIcon
data-testid={'snap-account-redirect-url-icon'}
data-testid="snap-account-redirect-url-icon"
onClick={() => {
global.platform.openTab({ url });
onSubmit?.();
}}
iconName={IconName.Export}
color={IconColor.primaryDefault}
size={ButtonIconSize.Sm}
ariaLabel={''}
ariaLabel=""
/>
);
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,8 @@ describe('<SnapAccountRedirect />', () => {
const { queryByTestId } = renderWithProvider(
<SnapAccountRedirect
snapId={mockSnapId}
url={''}
snapName={''}
url=""
snapName=""
isBlockedUrl={false}
message=""
/>,
Expand Down
Loading