-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support creation of Bitcoin testnet accounts #25772
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
079451d
to
0bc54c5
Compare
75a338b
to
805ac7b
Compare
Builds ready [805ac7b]
Page Load Metrics (65 ± 7 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25772 +/- ##
===========================================
+ Coverage 69.77% 69.95% +0.18%
===========================================
Files 1376 1394 +18
Lines 48403 48978 +575
Branches 13348 13476 +128
===========================================
+ Hits 33773 34261 +488
- Misses 14630 14717 +87 ☔ View full report in Codecov by Sentry. |
ui/components/multichain/create-btc-account/create-btc-account.tsx
Outdated
Show resolved
Hide resolved
1ec1120
to
bf2d25f
Compare
Builds ready [4763e46]
Page Load Metrics (399 ± 387 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Quality Gate passedIssues Measures |
Builds ready [42ebe44]
Page Load Metrics (162 ± 203 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works well on 42ebe44
} | ||
|
||
export function hasCreatedBtcTestnetAccount(state: AccountsState) { | ||
return hasCreatedBtcAccount(state, isBtcTestnetAddress); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isBtcTestnetAddress would return true for a non-EVM and non-BTC address. We can probably address this later when we support other non-EVM chains
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, and yes we would need to address this! Let's keep note of that for later
Missing release label release-12.2.0 on PR. Adding release label release-12.2.0 on PR and removing other release labels(release-12.3.0), as PR was cherry-picked in branch 12.2.0. |
Description
Adds support of testnet account within the extension following the same pattern than for mainnet accounts with a feature flag.
Related issues
Fixes: https://github.com/MetaMask/accounts-planning/issues/511
Manual testing steps
yarn start:flask
tb1q...
)Screenshots/Recordings
Screen.Recording.2024-07-11.at.16.37.19.mov
Pre-merge author checklist
Pre-merge reviewer checklist