feat: CAIP Multichain (OLD ignore. Only for reference now) #25665

jiexi · 2024-07-03T18:35:05Z

Description

~~This branch is becoming the feature branch for CAIP-25, CAIP-27, CAIP stream bifurcation, and CAIP-25 Permissions~~

This is branch is now stale.

develop (and core package) -> CAIP-25 permission migration (uses new core package) -> New multichain branch

Related issues

See: https://github.com/MetaMask/MetaMask-planning/issues/2360
See: MetaMask/test-dapp#324

Manual testing steps

Go to this page...

BARAD_DUR=1 CHAIN_PERMISSIONS=1 yarn start

Replace EXTENSION_ID with your local extension ID

const EXTENSION_ID = 'nonfpcflonapegmnfeafnddgdniflbnk';
const extensionPort = chrome.runtime.connect(EXTENSION_ID)
extensionPort.onMessage.addListener((msg) => console.log('extensionPort on message', msg))
extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        method: 'wallet_createSession',
        params: {
            requiredScopes: {
                'eip155': {
                    references: ['1', '59144'],
                    methods: [
                        'eth_sendTransaction',
                        'eth_accounts',
                        'eth_blockNumber',
                        'eth_getBalance',
                        'personal_sign',
                        'eth_requestAccounts',
                        'wallet_getPermissions',
                        'wallet_requestPermissions',
                        'wallet_revokePermissions',
                        'eth_chainId',
                        'wallet_switchEthereumChain'
                    ],
                    notifications: ['accountsChanged', 'chainChanged'],
                },
                'eip155:11155111': {
                    methods: ['eth_blockNumber'],
                    notifications: ['accountsChanged', 'chainChanged'],
                },
                'wallet': {
                    methods: [
                        'wallet_getPermissions',
                    ],
                    notifications: [],
                },
            },
            optionalScopes: {
                'eip155:64': {
                    methods: [
                        'eth_blockNumber',
                        'eth_getBalance',
                        'eth_getBlockByHash',
                        'eth_getBlockByNumber',
                    ],
                    notifications: ['accountsChanged', 'chainChanged'],
                },
            },
            sessionProperties: {
                expiry: 1,
                'caip154-mandatory': 'true',
            },
        },
    }
})
extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        "method": "wallet_invokeMethod",
        "params": {
            "sessionId": "0xdeadbeef",
            "scope": "eip155:1",
            "request": {
                "method": "eth_chainId",
            }
        }
    }
})
extensionPort.postMessage({
    type: 'caip-x',
    data: {
        "jsonrpc": "2.0",
        "method": "wallet_invokeMethod",
        "params": {
            "sessionId": "0xdeadbeef",
            "scope": "eip155:11155111",
            "request": {
                "method": "eth_chainId",
            }
        }
    }
})

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…nveloping

…rm with caip wrap/unwrap

…nveloping

…le-caip-enveloping' into jl/mmp-2528/externally_connectable-caip-enveloping

…nveloping

jiexi · 2024-10-09T17:54:27Z

html-report-caip27/index.html

need to remove this

## **Description** Remove unused error codes and skip wallet_getSession and revokeSession for now. bump schema-utils-js with a couple bug fixes. Fixed parsing ordering.  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27669?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** uncomment `revokeSession` and `getSession` and get them passing  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27741?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Jiexi Luan <[email protected]>

## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27745?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

# Conflicts: # app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.js # app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.test.js # app/scripts/lib/rpc-method-middleware/handlers/ethereum-chain-utils.js # app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js # app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.test.js # app/scripts/metamask-controller.js # package.json # test/e2e/api-specs/ConfirmationRejectionRule.ts # yarn.lock

jiexi · 2024-10-10T17:32:08Z

@metamaskbot update-policies

metamaskbot · 2024-10-10T17:43:16Z

No policy changes

## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27771?quickstart=1) ## **Related issues** See: MetaMask/MetaMask-planning#3483 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** Sets and reads eth accounts from/to `wallet:eip155` scope [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27769?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#3485 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description** On CAIP connection via externally_connectable: * subscription and middleware for permitted chains are now instantiated on connection open * i.e. if you restart your wallet, you should be able to make eth_subscribe calls for previously permitted dapps without having to call wallet_createSession first * subscription and middleware and are cleaned up on connection clos * i.e. you should not get any eth_subscriptions after refreshing the page and reconnecting * fix CAIP stream pipeline close handler not firing * whoops... * subscription and middleware are now also key'ed by tabId * i.e. subscriptions are isolated to the tabs they are started in [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27682?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#3451 ## **Manual testing steps** ``` const EXTENSION_ID = 'nonfpcflonapegmnfeafnddgdniflbnk'; const extensionPort = chrome.runtime.connect(EXTENSION_ID) extensionPort.onMessage.addListener((msg) => { // format wallet_notify events nicely so that we can read them more easily later if (msg.data.method === 'wallet_notify') { console.log('wallet_notify:', { scope: msg.data.params.scope, method: msg.data.params.notification.method, subscription: msg.data.params.notification.params.subscription, number: msg.data.params.notification.params.result.number }) return; } console.log(msg.data) }) extensionPort.postMessage({ type: 'caip-x', data: { "jsonrpc": "2.0", method: 'wallet_createSession', params: { requiredScopes: { }, optionalScopes: { 'eip155:1': { methods: [ 'eth_sendTransaction', 'eth_subscribe' ], notifications: ['eth_subscription'], accounts: [] }, 'eip155:11155111': { methods: [ 'eth_sendTransaction', 'eth_subscribe' ], notifications: ['eth_subscription'], accounts: ['eip155:11155111:0x5bA08AF1bc30f17272178bDcACA1C74e94955cF4', 'eip155:11155111:0xEe166a3eec4796DeC6A1D314e7485a52bBe68e4d'] }, 'eip155:59141': { methods: [ 'eth_sendTransaction', ], notifications: [], accounts: [] }, }, }, } }) extensionPort.postMessage({ type: 'caip-x', data: { "jsonrpc": "2.0", method: 'wallet_invokeMethod', params: { scope: 'eip155:11155111', request: { "method": "eth_subscribe", "params": [ "newHeads" ], } } } }) ``` ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Shane Jonas <[email protected]>

## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27777?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jiexi · 2024-10-10T20:35:41Z

app/scripts/metamask-controller.js

@@ -1540,7 +1534,7 @@ export default class MetamaskController extends EventEmitter {
        },
      },
      env: {
-        isAccountSyncingEnabled: isManifestV3,
+        isAccountSyncingEnabled: false, // TODO: undo this once fixed


## **Description** * Exclude permittedChains in eth_requestAccounts and wallet_requestPermissions if origin is snapId * Allow all subjectTypes to create endowment:caip25 permissions (this is the same as eth_accounts now, i.e. not limited to certain subject types) * Set eth accounts on upserted empty optional `wallet` and `wallet:eip155` scopes [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27803?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#3492 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27845?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…kConfigurationsByChainId property (#27849)  ## **Description**  [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/27849?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jiexi · 2024-10-15T16:19:25Z

This branch is now stale

jiexi · 2024-10-15T19:56:58Z

All comments have been copied out. This PR can be ignored now

jiexi added 30 commits June 5, 2024 15:53

add SplitStream specs

a9b741f

add CaipToMultiplexStream, MultiplexToCaipStream specs

7df64f3

lint

7db9d75

WIP createCaipStream spec

65c9d68

add createCaipStream specs

c8b66b5

lint

bbb33ae

Merge branch 'develop' into jl/mmp-2528/externally_connectable-caip-e…

edab0fe

…nveloping

add BARAD_DUR flag

040d300

dry background trackDappView

2acb719

move externally_connectable manifest wildcard behind BARAD_DUR

9792594

jsdoc

7372604

restore inpage

b82888b

Move caip stream closer to provider. Replace caip<->multiplex transfo…

64ca655

…rm with caip wrap/unwrap

Merge branch 'develop' into jl/mmp-2528/externally_connectable-caip-e…

714d044

…nveloping

Rename connectExternalDapp to connectExternalCaip

29ea68c

actually restore inpage

64ba990

Fix createCaipStream specs

46bfee7

use createDeferredPromise instead

e24ef63

rename onData to readFromStream

379ce8a

Merge branch 'develop' into jl/mmp-2528/externally_connectable-caip-e…

98ff148

…nveloping

fix method names. add setupUntrustedCommunicationCaip

cd3dd02

Merge branch 'develop' into jl/mmp-2528/externally_connectable-caip-e…

7f1eb8a

…nveloping

lint

cbfd014

Merge remote-tracking branch 'origin/jl/mmp-2528/externally_connectab…

5d65634

…le-caip-enveloping' into jl/mmp-2528/externally_connectable-caip-enveloping

lint

3652ab3

Merge branch 'develop' into jl/mmp-2528/externally_connectable-caip-e…

a239e64

…nveloping

Merge branch 'develop' into jl/mmp-2528/externally_connectable-caip-e…

4f4f999

…nveloping

Rename connectExternalLegacy to connectExternalExtension

5b667f2

rename _subjectType to inputSubjectType

0c3f000

use messenger where possible

ab7767b

jiexi commented Oct 9, 2024

View reviewed changes

html-report-caip27/index.html Outdated

Copy link

Contributor Author

jiexi Oct 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove this

shanejonas and others added 6 commits October 9, 2024 11:29

Merge branch 'develop' into caip-multichain

48d19e2

Merge branch 'develop' into caip-multichain

c3b7e52

jiexi and others added 4 commits October 10, 2024 12:04

jiexi commented Oct 10, 2024

View reviewed changes

jiexi added 12 commits October 11, 2024 10:08

Merge branch 'develop' into caip-multichain

2e06555

Merge branch 'develop' into caip-multichain

f4e0bb2

Merge branch 'develop' into caip-multichain

146f093

Merge branch 'develop' into caip-multichain

26dc532

Merge branch 'develop' into caip-multichain

28ba445

Merge branch 'develop' into caip-multichain

f66a26b

Merge branch 'develop' into caip-multichain

6adb2e4

Merge branch 'develop' into caip-multichain

df11376

Merge branch 'develop' into caip-multichain

71ed3aa

jiexi changed the title ~~feat: CAIP Multichain~~ feat: CAIP Multichain (OLD ignore. Only for reference now) Oct 15, 2024

jiexi closed this Oct 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: CAIP Multichain (OLD ignore. Only for reference now) #25665

feat: CAIP Multichain (OLD ignore. Only for reference now) #25665

jiexi commented Jul 3, 2024 •

edited

Loading

jiexi Oct 9, 2024

jiexi commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

jiexi Oct 10, 2024

jiexi commented Oct 15, 2024

jiexi commented Oct 15, 2024

feat: CAIP Multichain (OLD ignore. Only for reference now) #25665

feat: CAIP Multichain (OLD ignore. Only for reference now) #25665

Conversation

jiexi commented Jul 3, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

jiexi Oct 9, 2024

Choose a reason for hiding this comment

jiexi commented Oct 10, 2024

metamaskbot commented Oct 10, 2024

jiexi Oct 10, 2024

Choose a reason for hiding this comment

jiexi commented Oct 15, 2024

jiexi commented Oct 15, 2024

jiexi commented Jul 3, 2024 •

edited

Loading