-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace Typography with Text component in metametrics.js #25630
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25630 +/- ##
========================================
Coverage 69.60% 69.60%
========================================
Files 1364 1364
Lines 48173 48173
Branches 13291 13291
========================================
Hits 33527 33527
Misses 14646 14646 ☔ View full report in Codecov by Sentry. |
Builds ready [8ea961a]
Page Load Metrics (68 ± 14 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
- Checked
OnboardingMetametrics
storybook ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Refactored metametrics.js
to replace the Typography
component with the Text
component for improved consistency and maintainability.
- Updated
/ui/pages/onboarding-flow/metametrics/metametrics.js
to replace all instances ofTypography
withText
. - Adjusted import statements to include
Text
from../../../components/component-library
. - Ensured correct usage of
Text
component props for alignment, font weight, and text variants. - Verified no visual regressions through before and after screenshots.
- Thorough testing recommended to confirm no functionality or appearance changes.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice
Description
Migrated the
Typography
component to theText
component in themetametrics.js
file. This change is part of the ongoing effort to update the codebase to use the newText
component for better consistency and maintainability.Devin Run Link: https://staging.itsdev.in/devin/ab3388199a904772b66d750b70b340af
Related issues
Partially Fixes: #17670
Manual testing steps
OnboardingMetametrics
component renders correctlyScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist