Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: flaky E2E tests improved #25565

Merged
merged 14 commits into from
Jul 2, 2024
Merged

chore: flaky E2E tests improved #25565

merged 14 commits into from
Jul 2, 2024

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Jun 27, 2024

Description

Improvements to our E2E tests.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live added the team-mmi PRs from the MMI team label Jun 27, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4f26c5c]
Page Load Metrics (129 ± 164 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7515890189
domContentLoaded9201121
load401613129341164
domInteractive9201121
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (7d94797) to head (0fe4634).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25565   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48173    48173           
  Branches     13291    13291           
========================================
  Hits         33527    33527           
  Misses       14646    14646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zone-live zone-live changed the title chore: passes locally chore: flaky E2E tests improved Jun 28, 2024
@zone-live zone-live marked this pull request as ready for review July 1, 2024 13:24
@zone-live zone-live requested a review from a team as a code owner July 1, 2024 13:24
Copy link

sonarqubecloud bot commented Jul 2, 2024

@metamaskbot
Copy link
Collaborator

Builds ready [0fe4634]
Page Load Metrics (61 ± 6 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6312291157
domContentLoaded95627136
load398861136
domInteractive95527136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 7b69e3c into develop Jul 2, 2024
73 checks passed
@zone-live zone-live deleted the MMI-fixes-e2e-test branch July 2, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants