Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a story for GasTiming component #25557

Merged
merged 15 commits into from
Jul 30, 2024
Merged

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 27, 2024

Description

This pull request adds a Storybook story for the GasTiming component in the MetaMask extension. The reason for this change is to enable isolated testing and visualization of the GasTiming component within Storybook. The improvement/solution provided by this change is the ability to interact with and test the GasTiming component in isolation, ensuring it renders correctly and behaves as expected.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Go to the latest build of Storybook in this PR.
  2. Navigate to the GasTiming component in the Components/ folder.

Screenshots/Recordings

Screenshot 2024-07-26 at 4 29 06 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

This Devin run was requested by Devin.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@devin-ai-integration devin-ai-integration bot changed the title chore: Create a story for gas-timing component chore: Create a story for GasTiming component Jun 27, 2024
@garrettbear garrettbear added team-design-system All issues relating to design system in Extension external-contributor labels Jun 27, 2024
.gitignore Outdated Show resolved Hide resolved
@georgewrmarshall georgewrmarshall requested a review from a team July 15, 2024 17:38
@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed external-contributor labels Jul 25, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [4603362]
Page Load Metrics (342 ± 382 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint772511234119
domContentLoaded97628178
load492866342797382
domInteractive97628178
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.98%. Comparing base (6eafd29) to head (81cfe25).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25557   +/-   ##
========================================
  Coverage    69.98%   69.98%           
========================================
  Files         1409     1409           
  Lines        49856    49856           
  Branches     13779    13779           
========================================
  Hits         34887    34887           
  Misses       14969    14969           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 26, 2024 23:29
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 26, 2024 23:29
Copy link

@metamaskbot
Copy link
Collaborator

Builds ready [81cfe25]
Page Load Metrics (285 ± 309 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint792721204220
domContentLoaded106124136
load462333285644309
domInteractive106124136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@georgewrmarshall georgewrmarshall merged commit 81476bb into develop Jul 30, 2024
75 checks passed
@georgewrmarshall georgewrmarshall deleted the devin/story-aXx branch July 30, 2024 21:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Jul 30, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants