-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Create a story for GasTiming component #25557
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
3d1d8e7
to
b8485e7
Compare
fb96958
to
aba028f
Compare
Builds ready [4603362]
Page Load Metrics (342 ± 382 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25557 +/- ##
========================================
Coverage 69.98% 69.98%
========================================
Files 1409 1409
Lines 49856 49856
Branches 13779 13779
========================================
Hits 34887 34887
Misses 14969 14969 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ui/pages/confirmations/components/gas-timing/gas-timing.stories.tsx
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Builds ready [81cfe25]
Page Load Metrics (285 ± 309 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤘
Description
This pull request adds a Storybook story for the
GasTiming
component in the MetaMask extension. The reason for this change is to enable isolated testing and visualization of theGasTiming
component within Storybook. The improvement/solution provided by this change is the ability to interact with and test theGasTiming
component in isolation, ensuring it renders correctly and behaves as expected.Related issues
Fixes: N/A
Manual testing steps
GasTiming
component in theComponents/
folder.Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist
This Devin run was requested by Devin.