Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace deprecated mixins with text component in loading-swaps-quotes #25553

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jun 27, 2024

Description

This pull request replaces deprecated mixins with the Text component in the loading-swaps-quotes file. The changes include updating the SCSS and JS files to use the Text component and related enums, as well as deleting specific SCSS instances as instructed by the user.

Devin Run Link: https://staging.itsdev.in/devin/edffa827e63141c8a3214c25ecf4a760

Open in GitHub Codespaces

Related issues

Partially Fixes: #20496

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Manually check if LoadingSwapQuotes is getting rendered properly

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@consensys-devin
Copy link

Tagging @georgewrmarshall for review

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (83e4b2a) to head (1cb277e).
Report is 19 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25553   +/-   ##
========================================
  Coverage    69.67%   69.67%           
========================================
  Files         1405     1405           
  Lines        49728    49728           
  Branches     13748    13748           
========================================
  Hits         34646    34646           
  Misses       15082    15082           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [94259f1]
Page Load Metrics (46 ± 3 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint63977795
domContentLoaded8171021
load40664663
domInteractive8171021
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 676 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 28, 2024
@georgewrmarshall georgewrmarshall requested a review from a team June 28, 2024 17:02
@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 28, 2024 17:02
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner June 28, 2024 17:02
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

  • Checked styles were correctly replaced with Text component API ✅
  • Checked storybook ✅

@georgewrmarshall georgewrmarshall requested review from a team and garrettbear July 24, 2024 00:38
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 24, 2024 16:36
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Refactored loading-swaps-quotes to replace deprecated mixins with the Text component, improving UI consistency and reducing CSS.

  • File: ui/pages/swaps/loading-swaps-quotes/index.scss

    • Removed deprecated mixins and associated styles.
  • File: ui/pages/swaps/loading-swaps-quotes/loading-swaps-quotes.js

    • Replaced deprecated mixins with Text component.
    • Updated Text component props for quote counter and name check elements.
    • Ensured alignment with modern design standards using TextVariant and other style properties.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

(updates since last review)

Refactored loading-swaps-quotes to replace deprecated mixins with the Text component, improving UI consistency and reducing CSS.

  • File: test/e2e/accounts/account-custom-name.spec.ts

    • Updated button click method for improved test reliability.
  • File: test/e2e/accounts/common.ts

    • Added delay to ensure popup window closure before proceeding.
  • File: test/e2e/accounts/create-snap-account.spec.ts

    • Introduced steps to wait for popup closure, enhancing test stability.
  • File: test/e2e/webdriver/chrome.js

    • Temporarily locked Chrome version to 126 for test compatibility.
  • File: ui/components/app/import-token/token-list/token-list.component.js

    • Removed showHalo prop from AvatarToken component.

8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@metamaskbot
Copy link
Collaborator

Builds ready [1cb277e]
Page Load Metrics (157 ± 169 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681441032110
domContentLoaded116635189
load411685157351169
domInteractive116635189
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 676 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed external-contributor labels Jul 25, 2024
@georgewrmarshall georgewrmarshall merged commit 73460d5 into develop Aug 12, 2024
79 checks passed
@georgewrmarshall georgewrmarshall deleted the devin/mixin-xyz branch August 12, 2024 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Aug 12, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 12, 2024
@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace deprecated mixins @include H1 - @include H9 in SCSS with Text component
7 participants