-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace deprecated mixins with text component in loading-swaps-quotes #25553
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Tagging @georgewrmarshall for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25553 +/- ##
========================================
Coverage 69.67% 69.67%
========================================
Files 1405 1405
Lines 49728 49728
Branches 13748 13748
========================================
Hits 34646 34646
Misses 15082 15082 ☔ View full report in Codecov by Sentry. |
Builds ready [94259f1]
Page Load Metrics (46 ± 3 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Checked styles were correctly replaced with Text component API ✅
- Checked storybook ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Refactored loading-swaps-quotes
to replace deprecated mixins with the Text
component, improving UI consistency and reducing CSS.
-
File:
ui/pages/swaps/loading-swaps-quotes/index.scss
- Removed deprecated mixins and associated styles.
-
File:
ui/pages/swaps/loading-swaps-quotes/loading-swaps-quotes.js
- Replaced deprecated mixins with
Text
component. - Updated
Text
component props for quote counter and name check elements. - Ensured alignment with modern design standards using
TextVariant
and other style properties.
- Replaced deprecated mixins with
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
(updates since last review)
Refactored loading-swaps-quotes
to replace deprecated mixins with the Text
component, improving UI consistency and reducing CSS.
-
File:
test/e2e/accounts/account-custom-name.spec.ts
- Updated button click method for improved test reliability.
-
File:
test/e2e/accounts/common.ts
- Added delay to ensure popup window closure before proceeding.
-
File:
test/e2e/accounts/create-snap-account.spec.ts
- Introduced steps to wait for popup closure, enhancing test stability.
-
File:
test/e2e/webdriver/chrome.js
- Temporarily locked Chrome version to 126 for test compatibility.
-
File:
ui/components/app/import-token/token-list/token-list.component.js
- Removed
showHalo
prop fromAvatarToken
component.
- Removed
8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Builds ready [1cb277e]
Page Load Metrics (157 ± 169 ms)
Bundle size diffs
|
Description
This pull request replaces deprecated mixins with the Text component in the
loading-swaps-quotes
file. The changes include updating the SCSS and JS files to use the Text component and related enums, as well as deleting specific SCSS instances as instructed by the user.Devin Run Link: https://staging.itsdev.in/devin/edffa827e63141c8a3214c25ecf4a760
Related issues
Partially Fixes: #20496
Manual testing steps
LoadingSwapQuotes
is getting rendered properlyScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist