Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support IPFS CID Blocking #25533

Closed
wants to merge 15 commits into from
Closed

feat: Support IPFS CID Blocking #25533

wants to merge 15 commits into from
+181 −85

Conversation

409H
Copy link
Contributor

@409H 409H commented Jun 26, 2024 •
edited
Loading

Pass full sender URL to the PhishingController for v2.0.0 to support IPFS CID blocking

Requires the following:

Once this is merged, we then can merge:

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@409H 409H requested a review from a team as a code owner June 26, 2024 20:41
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@409H 409H marked this pull request as draft June 26, 2024 20:42
@socket-security Socket Security
Copy link

socket-security bot commented Jul 28, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/[email protected])

View full report↗︎

AugmentedMode
AugmentedMode requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@AugmentedMode AugmentedMode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will approve once merege conflicts are fixed

@AugmentedMode AugmentedMode changed the title Support IPFS CID Blocking Feat: Support IPFS CID Blocking Aug 15, 2024
@AugmentedMode AugmentedMode changed the title Feat: Support IPFS CID Blocking feat: Support IPFS CID Blocking Aug 15, 2024
@AugmentedMode AugmentedMode self-assigned this Aug 15, 2024
@AugmentedMode AugmentedMode added team-ai AI team (for the Devin AI bot) team-product-safety Push issues to Product Safety team and removed team-ai AI team (for the Devin AI bot) labels Aug 15, 2024
@AugmentedMode
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policy update failed. You can review the logs or retry the policy update here

@metamaskbot
Copy link
Collaborator

Policies updated

@AugmentedMode
Copy link
Contributor

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AugmentedMode AugmentedMode deleted the enhancement/phishing-ipfs-cid branch August 30, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AugmentedMode AugmentedMode AugmentedMode requested changes

Assignees

@AugmentedMode AugmentedMode

Labels
team-product-safety Push issues to Product Safety team type-enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@409H @AugmentedMode @metamaskbot