fix: flaky test onboarding @no-mmi doesn't make any network requests to infura before onboarding is completed/test-failure-screenshot-1.png timeout

[seaona]

Description

This test appears flaky as sometimes not all the requests are made when we finish the onboarding. Notice how, we mock 5 requests, but in the logs, only 4 appear after the onboarding. Specifically the net_version request doesn't happen in this case.

[EDIT] It seems that the explanation for this is what @HowardBraham mentions below: since we mock the balance as non-zero, the wallet keeps querying the balance for the subsequent accounts. This could be that causes the wallet to enter in a non-finishing loop, and the net_version request is also never triggered (see this should happen after the eth_call)

Related issues

Fixes: #25543

Manual testing steps

1. Check ci

Screenshots/Recordings

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[HowardBraham]

@seaona I think I figured this one out. The mocked eth_getBalance is returning a balance of 0x1 on every account, and because the balance is nonzero, it tries to get the balance of the next account. Here's a screenshot showing more than 100 accounts:

I think the solution is:
result: '0x0',
so that it stops querying accounts

[seaona]

hey @HowardBraham that's a great finding!!! I confirm I've observed this behaviour occasionally, where the accounts kept growing if I wait several seconds.
Also this could be the cause of the net_version req never happen as it got stuck at the eth_call

[EDIT] It looks like this works on ci. I've also run the test several times locally and seems to fix it! thank you. I've updated the description accordingly

net-verison-missing.mp4

[metamaskbot]

Builds ready [604ace6]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (48 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	102	79	9	5
		domContentLoaded	9	14	11	1	1
		load	39	65	48	8	4
		domInteractive	9	14	11	1	1

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[chloeYue]

Wow great findings ! LGTM !