refactor: fix event names used to track notifications

[matteoscurati]

Description

This PR modifies the names of some tracked events to monitor the use of notifications, ensuring they adhere to the conventions used.

Related issues

Fixes:

Manual testing steps

1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[greptile-apps]

PR Summary

This PR updates event names and properties for tracking notifications to ensure consistency and adherence to conventions.

• app/scripts/metamask-controller.js: Renamed PushNotificationClicked to NotificationClicked and added properties like notification_id, notification_is_read, and click_type.
• shared/constants/metametrics.ts: Standardized MetaMetrics event names for better consistency.
• ui/components/app/modals/turn-on-metamask-notifications/turn-on-metamask-notifications.tsx: Updated event names and added properties is_notifications_enabled and action_type.
• ui/components/multichain/global-menu/global-menu.js: Renamed event names and properties for notification tracking.
• ui/pages/notifications-settings/notifications-settings-allow-notifications.tsx: Replaced specific event names with NotificationsSettingsUpdated and added properties setting_type, old_value, and new_value.

_{12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings}

[metamaskbot]

Builds ready [d7c77cd]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (227 ± 226 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	297	106	49	24
		domContentLoaded	9	105	29	23	11
		load	41	1763	227	471	226
		domInteractive	9	105	29	23	11

Bundle size diffs [🚀 Bundle size reduced!]

• background: 102 Bytes (0.00%)
• ui: -771 Bytes (-0.01%)
• common: -976 Bytes (-0.01%)

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.95%. Comparing base (b27dd2b) to head (d7c77cd).

Files	Patch %	Lines
...ation-detail-button/notification-detail-button.tsx	0.00%	1 Missing ⚠️
ui/pages/notifications/notifications-list-item.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25521      +/-   ##
===========================================
+ Coverage    69.94%   69.95%   +0.01%     
===========================================
  Files         1409     1409              
  Lines        49794    49779      -15     
  Branches     13773    13767       -6     
===========================================
- Hits         34826    34818       -8     
+ Misses       14968    14961       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[metamaskbot]

Builds ready [5a7ea8e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9
  • content-script: 0
  • offscreen: 0
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (60 ± 7 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	114	87	13	6
		domContentLoaded	8	53	24	12	6
		load	40	97	60	14	7
		domInteractive	8	53	24	12	6

Bundle size diffs [🚀 Bundle size reduced!]

• background: 102 Bytes (0.00%)
• ui: -771 Bytes (-0.01%)
• common: -976 Bytes (-0.01%)