Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding max with to send page in expanded view #25511

Closed
wants to merge 1 commit into from

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Jun 25, 2024

Description

This pull request introduces a maximum width of 480px to the send screen in expanded view. This change is intended to enhance the user interface by preventing it from taking up 100% of the screen width on larger screens, thereby improving the visual presentation and user experience.

Related slack thread

https://warpcast.com/antimofm.eth/0x487c8c0e

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Open the extension in expanded view
  2. Select "Send" button from home page
  3. See send screen is no longer 100% width of large screens

Screenshots/Recordings

Before

before720.mov

After

after720.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Extension label Jun 25, 2024
@@ -2,6 +2,7 @@

.multichain-send-page {
width: 100%;
max-width: 480px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with our container component and the max width set. The reason I didn't use the Container component is that it would require a fair amount of refactoring.

Screenshot 2024-06-25 at 9:41:19 AM

@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed team-ai AI team (for the Devin AI bot) labels Jul 25, 2024
@georgewrmarshall
Copy link
Contributor Author

Seems like this has been resolved

@georgewrmarshall georgewrmarshall deleted the fix/send-page-max-width branch July 31, 2024 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants