-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [Snaps E2E] Create test for snap dialog JSX functionality #25493
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25493 +/- ##
========================================
Coverage 69.65% 69.65%
========================================
Files 1355 1355
Lines 48007 48007
Branches 13235 13235
========================================
Hits 33437 33437
Misses 14570 14570 ☔ View full report in Codecov by Sentry. |
Builds ready [01fd4ff]
Page Load Metrics (175 ± 194 ms)
Bundle size diffs
|
Builds ready [7505d43]
Page Load Metrics (669 ± 469 ms)
Bundle size diffs
|
Quality Gate passedIssues Measures |
Builds ready [cd43d7a]
Page Load Metrics (227 ± 231 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Description
Related issues
Fixes: #25224
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist