-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky test vault-decrypt
by removing driver navigate to open a new window
#25443
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25443 +/- ##
========================================
Coverage 65.39% 65.39%
========================================
Files 1382 1382
Lines 54764 54764
Branches 14369 14369
========================================
Hits 35809 35809
Misses 18955 18955 ☔ View full report in Codecov by Sentry. |
Builds ready [265d1e3]
Page Load Metrics (49 ± 3 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proxy exception is harmless.
Description
The vault decryption test opens 2 MetaMask windows whenever we start the test, causing flakiness in which window is currently selected and where the actions are performed.
Having 2 MM windows, together with the fact that the Chrome active window can sometimes not be the same as the Webdriver active window (see @HowardBraham 's work on that area), causes unpredictable effects - see video below.
For fixing it, we now remove the step of
driver.navigate
which will open a MM window, and caused to have 2 windows instead of 1.However, this lead to a new problem. Lavamoat presents a race condition, which now is more present making the test fail in almost all runs. From @naugtur :
For fixing this, we add
Proxy
in the exceptions, following Lavamoat's team suggestion as a temporary solution.mm-vault-decrypt-error.mp4
Related issues
Fixes:
Manual testing steps
See successful run here
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist