Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace typography with text component in signature request original component #25300

Conversation

Devin-Apps
Copy link
Contributor

@Devin-Apps Devin-Apps commented Jun 13, 2024

Description

This pull request migrates the Typography component to the Text component in the signature-request-original.component.js file. The reason for this change is to align with the updated design specifications and improve the consistency of the codebase. The improvement includes replacing the old Typography component with the new Text component, ensuring the correct usage of TextVariant and other related enums.

Devin Run Link: https://preview.devin.ai/devin/603cd12e77ea42838afb65610cc55388

Open in GitHub Codespaces

Related issues

Partially Fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Check if SignatureRequestOriginal is getting rendered properly

Screenshots/Recordings

Before

Screenshot 2024-06-13 at 21 02 41 Screenshot 2024-06-13 at 21 02 46 Screenshot 2024-06-13 at 21 02 50 Screenshot 2024-06-13 at 21 02 54

After

Screenshot 2024-06-13 at 20 52 53 Screenshot 2024-06-13 at 20 53 04 Screenshot 2024-06-13 at 20 53 11 Screenshot 2024-06-13 at 20 53 16

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall requested a review from a team June 13, 2024 16:35
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 13, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 13, 2024 20:36
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner June 13, 2024 20:36
@georgewrmarshall georgewrmarshall marked this pull request as draft June 14, 2024 15:52
@georgewrmarshall georgewrmarshall changed the title refactor : Replace Typography with Text component in signature-request-original.component.js refactor: Replace Typography with Text component in signature-request-original.component.js Jun 24, 2024
@georgewrmarshall georgewrmarshall changed the title refactor: Replace Typography with Text component in signature-request-original.component.js refactor: replace typography with text component in signature request original component Jun 24, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (d403213) to head (a8b2f4e).
Report is 275 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25300   +/-   ##
========================================
  Coverage    69.69%   69.69%           
========================================
  Files         1350     1350           
  Lines        47865    47865           
  Branches     13199    13199           
========================================
  Hits         33355    33355           
  Misses       14510    14510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment just need to re-arrange component imports

Comment on lines +34 to 38
Text,
///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
Box,
Icon,
IconName,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be respecting environment tags ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) and order of imports. Place the Text component import back inside of the ///: BEGIN:ONLY_INCLUDE_IF(build-mmi) tag

Suggested change
Text,
///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
Box,
Icon,
IconName,
///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
Box,
Icon,
IconName,
Text,

@georgewrmarshall georgewrmarshall added team-ai AI team (for the Devin AI bot) and removed external-contributor labels Jul 25, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-ai AI team (for the Devin AI bot) team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
3 participants