-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace typography with text component in signature request original component #25300
refactor: replace typography with text component in signature request original component #25300
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
.../confirmations/components/signature-request-original/signature-request-original.component.js
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25300 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 1350 1350
Lines 47865 47865
Branches 13199 13199
========================================
Hits 33355 33355
Misses 14510 14510 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment just need to re-arrange component imports
Text, | ||
///: BEGIN:ONLY_INCLUDE_IF(build-mmi) | ||
Box, | ||
Icon, | ||
IconName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be respecting environment tags ///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
and order of imports. Place the Text component import back inside of the ///: BEGIN:ONLY_INCLUDE_IF(build-mmi)
tag
Text, | |
///: BEGIN:ONLY_INCLUDE_IF(build-mmi) | |
Box, | |
Icon, | |
IconName, | |
///: BEGIN:ONLY_INCLUDE_IF(build-mmi) | |
Box, | |
Icon, | |
IconName, | |
Text, |
Description
This pull request migrates the
Typography
component to theText
component in thesignature-request-original.component.js
file. The reason for this change is to align with the updated design specifications and improve the consistency of the codebase. The improvement includes replacing the oldTypography
component with the newText
component, ensuring the correct usage ofTextVariant
and other related enums.Devin Run Link: https://preview.devin.ai/devin/603cd12e77ea42838afb65610cc55388
Related issues
Partially Fixes: #17670
Manual testing steps
SignatureRequestOriginal
is getting rendered properlyScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist