Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace typography with text component in review recovery phrase #25265

Merged

Conversation

Devin-Apps
Copy link
Contributor

@Devin-Apps Devin-Apps commented Jun 12, 2024

Description

Migrated the Typography component to the Text component in the review-recovery-phrase.js file. This change is part of the ongoing effort to update the codebase to use the new Text component for better consistency and maintainability.

Devin Run Link: https://preview.devin.ai/devin/f2332a51ed044002a120b3867453f270

Open in GitHub Codespaces

Related issues

Partially Fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Verify that the ReviewRecoveryPhrase component renders correctly with the new Text component
  3. Ensure that the styling and functionality remain consistent with the previous implementation

Screenshots/Recordings

Before

After

after

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Devin-Apps
Copy link
Contributor Author

Tagging @georgewrmarshall for review

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.69%. Comparing base (d403213) to head (2c58e27).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25265   +/-   ##
========================================
  Coverage    69.69%   69.69%           
========================================
  Files         1350     1350           
  Lines        47865    47865           
  Branches     13199    13199           
========================================
  Hits         33355    33355           
  Misses       14510    14510           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall requested a review from a team June 13, 2024 16:36
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 13, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Left one suggestion

@georgewrmarshall georgewrmarshall changed the title refactor : Replace Typography with Text component in review-recovery-phrase.js refactor: replace typography with text component in review recovery phrase Jun 25, 2024
@georgewrmarshall georgewrmarshall requested a review from a team June 28, 2024 17:03
@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 23, 2024 23:37
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 23, 2024 23:37
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • checked storybook ✅
  • checked branch locally ✅
Screenshot 2024-07-23 at 3 46 03 PM

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Refactored review-recovery-phrase.js to replace the Typography component with the Text component for improved consistency and maintainability.

  • Updated /ui/pages/onboarding-flow/recovery-phrase/review-recovery-phrase.js to replace all instances of Typography with Text.
  • Adjusted import statements and props to align with the Text component API.
  • Ensured that the new Text component maintains the same styling and functionality as the deprecated Typography component.
  • Verified that the ReviewRecoveryPhrase component renders correctly with the new Text component.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@garrettbear garrettbear merged commit aee6585 into MetaMask:develop Jul 24, 2024
70 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2024
@metamaskbot metamaskbot added the release-12.4.0 Issue or pull request that will be included in release 12.4.0 label Aug 15, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.4.0 on PR, as PR was added to branch 12.4.0 when release was cut.

@gauthierpetetin gauthierpetetin added release-12.3.0 Issue or pull request that will be included in release 12.3.0 and removed release-12.4.0 Issue or pull request that will be included in release 12.4.0 labels Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-12.3.0 Issue or pull request that will be included in release 12.3.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
5 participants