-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace typography with text component in review recovery phrase #25265
refactor: replace typography with text component in review recovery phrase #25265
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Tagging @georgewrmarshall for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25265 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 1350 1350
Lines 47865 47865
Branches 13199 13199
========================================
Hits 33355 33355
Misses 14510 14510 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Left one suggestion
ui/pages/onboarding-flow/recovery-phrase/review-recovery-phrase.js
Outdated
Show resolved
Hide resolved
ui/pages/onboarding-flow/recovery-phrase/review-recovery-phrase.js
Outdated
Show resolved
Hide resolved
Co-authored-by: George Marshall <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Refactored review-recovery-phrase.js
to replace the Typography
component with the Text
component for improved consistency and maintainability.
- Updated
/ui/pages/onboarding-flow/recovery-phrase/review-recovery-phrase.js
to replace all instances ofTypography
withText
. - Adjusted import statements and props to align with the
Text
component API. - Ensured that the new
Text
component maintains the same styling and functionality as the deprecatedTypography
component. - Verified that the
ReviewRecoveryPhrase
component renders correctly with the newText
component.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
No release label on PR. Adding release label release-12.4.0 on PR, as PR was added to branch 12.4.0 when release was cut. |
Description
Migrated the
Typography
component to theText
component in thereview-recovery-phrase.js
file. This change is part of the ongoing effort to update the codebase to use the newText
component for better consistency and maintainability.Devin Run Link: https://preview.devin.ai/devin/f2332a51ed044002a120b3867453f270
Related issues
Partially Fixes: #17670
Manual testing steps
ReviewRecoveryPhrase
component renders correctly with the newText
componentScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist