-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add fuzzy matching for name lookup #25264
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25264 +/- ##
===========================================
- Coverage 64.93% 64.92% -0.00%
===========================================
Files 1385 1385
Lines 54870 54874 +4
Branches 14408 14408
===========================================
Hits 35625 35625
- Misses 19245 19249 +4 ☔ View full report in Codecov by Sentry. |
ui/pages/settings/contact-list-tab/add-contact/add-contact.component.js
Outdated
Show resolved
Hide resolved
Builds ready [394770d]
Page Load Metrics (114 ± 149 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [c645fc4]
Page Load Metrics (228 ± 244 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed files owned by confirmation team, changes look good 👍
Builds ready [859d098]
Page Load Metrics (60 ± 6 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
domainName
property that the UI can display.domainName
returned in the snap response instead ofuserInput
.Demo:
Screen.Recording.2024-06-20.at.8.49.16.AM.mov
Pre-merge author checklist
Pre-merge reviewer checklist