Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Part of #17670- Replace Typography with Text component in confirm-recovery-phrase.js #25019

Conversation

Devin-Apps
Copy link
Contributor

@Devin-Apps Devin-Apps commented Jun 4, 2024

Description

Migrated the Typography component to the Text component in the confirm-recovery-phrase.js file, ensuring that specific variants and props are updated accordingly.

Devin Preview Link

https://preview.devin.ai/devin/fb1ad1cf9af64c40b1eb876b52b7b79c

Related issues

Partially Fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Manually check if the page ConfirmRecoveryPhrase renders correctly

Screenshots

Before

After

con

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 4, 2024
@georgewrmarshall georgewrmarshall self-assigned this Jun 4, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 6, 2024
@georgewrmarshall georgewrmarshall requested a review from a team June 6, 2024 21:52
@Devin-Apps Devin-Apps marked this pull request as ready for review June 7, 2024 02:48
@Devin-Apps Devin-Apps requested a review from a team as a code owner June 7, 2024 02:48
@Devin-Apps Devin-Apps marked this pull request as draft June 7, 2024 02:48
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.63%. Comparing base (fbd9bbd) to head (40456ab).
Report is 18 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25019      +/-   ##
===========================================
- Coverage    65.63%   65.63%   -0.00%     
===========================================
  Files         1367     1367              
  Lines        54266    54266              
  Branches     14194    14194              
===========================================
- Hits         35614    35613       -1     
- Misses       18652    18653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall removed their assignment Jun 11, 2024
@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 11, 2024 22:05
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@georgewrmarshall georgewrmarshall removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024
@georgewrmarshall georgewrmarshall removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024
@georgewrmarshall georgewrmarshall requested a review from a team June 12, 2024 22:23
@garrettbear garrettbear merged commit 82efbdf into MetaMask:develop Jun 13, 2024
90 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
5 participants