-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Part of #17670 - Replace Typography with Text component in ui/components/ui/chip/chip.js #25017
refactor: Part of #17670 - Replace Typography with Text component in ui/components/ui/chip/chip.js #25017
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just need to update snapshots yarn jest --updateSnapshot
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25017 +/- ##
===========================================
- Coverage 65.63% 65.63% -0.00%
===========================================
Files 1367 1367
Lines 54266 54266
Branches 14194 14194
===========================================
- Hits 35614 35613 -1
- Misses 18652 18653 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤖🔥
Because this component is used in the recovery phrase I made sure to test the onboarding flow
after720.mov
No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut. |
Description
Migrate Typography to Text component in Chip component. This change is part of the effort to standardize text rendering across the application and ensure consistency in the design system. Before and after screenshots have been provided to ensure no visual regressions.
Devin Preview Link
https://preview.devin.ai/devin/2c41e8916ed14a95ae831b29501815ff
Related issues
Partially fixes: #17670
Manual testing steps
Chip
renders correctlyScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist