Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Part of #17670 - Replace Typography with Text component in ui/components/ui/chip/chip.js #25017

Merged

Conversation

Devin-Apps
Copy link
Contributor

@Devin-Apps Devin-Apps commented Jun 4, 2024

Description

Migrate Typography to Text component in Chip component. This change is part of the effort to standardize text rendering across the application and ensure consistency in the design system. Before and after screenshots have been provided to ensure no visual regressions.

Devin Preview Link

https://preview.devin.ai/devin/2c41e8916ed14a95ae831b29501815ff

Related issues

Partially fixes: #17670

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Manually check if the page Chip renders correctly

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added external-contributor INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 4, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just need to update snapshots yarn jest --updateSnapshot

@georgewrmarshall georgewrmarshall self-assigned this Jun 4, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 6, 2024
@georgewrmarshall georgewrmarshall requested a review from a team June 11, 2024 21:10
@georgewrmarshall georgewrmarshall removed their assignment Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.63%. Comparing base (fbd9bbd) to head (e85ce6e).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #25017      +/-   ##
===========================================
- Coverage    65.63%   65.63%   -0.00%     
===========================================
  Files         1367     1367              
  Lines        54266    54266              
  Branches     14194    14194              
===========================================
- Hits         35614    35613       -1     
- Misses       18652    18653       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 12, 2024 16:51
@georgewrmarshall georgewrmarshall requested review from a team as code owners June 12, 2024 16:51
@metamaskbot metamaskbot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 12, 2024
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤖🔥

Because this component is used in the recovery phrase I made sure to test the onboarding flow

after720.mov

@georgewrmarshall georgewrmarshall requested a review from a team June 12, 2024 22:53
@georgewrmarshall georgewrmarshall merged commit 95b10da into MetaMask:develop Jun 13, 2024
81 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 13, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 19, 2024
@metamaskbot
Copy link
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
external-contributor release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace deprecated Typography with Text component
6 participants