Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/attributions #24867

Closed
wants to merge 33 commits into from
Closed

Fix/attributions #24867

wants to merge 33 commits into from

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented May 29, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

cryptodev-2s and others added 30 commits May 16, 2024 14:43
@cryptodev-2s
feat: add new attributions workflow
80f4d6a
@cryptodev-2s
fix: add missing runs-on on update-attributions gh action
4b82bba
@cryptodev-2s
fix: update readme
4f86499
@cryptodev-2s
feat: add attribution check gh action
ae202cd
@cryptodev-2s
fix: update check attribution action trigger
2146983
@cryptodev-2s
fix: attributions check gh action
6fac431
@cryptodev-2s
fix: check attribution gh action remove useless pr checkout by number
afec127
@cryptodev-2s
fix: update attribution file
aba129c
@cryptodev-2s
fix: remove fork check on attributions update
8dc080f
@cryptodev-2s
fix: attribution script
3c8d14e
@cryptodev-2s
fix: restore .gitignore
256fb51
@metamaskbot @cryptodev-2s
Update LavaMoat policies
56f6d84
@cryptodev-2s
fix: run yarn dedupe
ccc3bd6
@metamaskbot @cryptodev-2s
Update LavaMoat policies
8a6ee29
@cryptodev-2s
fix: update attributions
ee20d14
@cryptodev-2s
fix: attribution script to use node instead of python
2ecc8f0
@cryptodev-2s
fix: update attributions
91051c2
@cryptodev-2s
fix: update attribution
469efeb
@cryptodev-2s
Extract yarnrc override script
d3373d1
@cryptodev-2s
Merge remote-tracking branch 'origin/develop' into fix/attributions
9cd958a
@cryptodev-2s
Update attributions
2d31777
@cryptodev-2s
Merge remote-tracking branch 'origin/develop' into fix/attributions
49960b2
@cryptodev-2s
fix: attributions
1005376
@cryptodev-2s
Merge branch 'develop' into fix/attributions
f05f31d
@cryptodev-2s
fix: refactor check attribution action
cf29c2c
@cryptodev-2s
Merge remote-tracking branch 'origin/develop' into fix/attributions
41493b4
@cryptodev-2s
fix: update attribution file
7de46d4
@cryptodev-2s
fix: attribution typo
3a8b245
@cryptodev-2s
fix: attribution typo
4aeb511
@cryptodev-2s
fix: attribution check
b2ecf5a
@cryptodev-2s cryptodev-2s requested review from a team and kumavis as code owners May 29, 2024 14:13
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cryptodev-2s @metamaskbot