Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure privacy policy state persists properly #24850

Merged
merged 1 commit into from
May 28, 2024

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented May 28, 2024

Description

@danjm reported that the Privacy Policy wasn't disappearing after being interacted with. The problem is that the stored setting is overidden by initState being spread into the arguments.

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Set PRIVACY_POLICY_DATE in ui/helpers/constants/privacy-policy.ts to today's date
  2. Click to dismiss the privacy policy
  3. See the privacy policy toast disappear

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner May 28, 2024 22:30
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing merged commit ac82f18 into develop May 28, 2024
75 of 77 checks passed
@darkwing darkwing deleted the fix-privacy-storage branch May 28, 2024 23:29
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [30a27f4]
Page Load Metrics (943 ± 567 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint671781072814
domContentLoaded9261442
load5629159431180567
domInteractive9261442
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants