-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Reduce e2e attempts from 3 to 2 in CircleCI #24531
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
added
area-CI
team-security
e2e-test
End to end test for the MetaMask extension
labels
May 14, 2024
hjetpoluru
previously approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
legobeat
force-pushed
the
e2e-decrease-retries
branch
from
May 16, 2024 22:08
f36f251
to
f955d27
Compare
legobeat
force-pushed
the
e2e-decrease-retries
branch
from
May 23, 2024 11:22
fcab3dd
to
353b7e0
Compare
seaona
previously approved these changes
May 23, 2024
legobeat
force-pushed
the
e2e-decrease-retries
branch
9 times, most recently
from
May 23, 2024 19:13
fa9d9c1
to
fb946ff
Compare
legobeat
force-pushed
the
e2e-decrease-retries
branch
from
May 31, 2024 05:47
d659566
to
17502bd
Compare
digiwand
approved these changes
May 31, 2024
legobeat
force-pushed
the
e2e-decrease-retries
branch
12 times, most recently
from
May 31, 2024 10:16
8508a6d
to
7951645
Compare
hjetpoluru
approved these changes
May 31, 2024
DDDDDanica
approved these changes
May 31, 2024
legobeat
force-pushed
the
e2e-decrease-retries
branch
7 times, most recently
from
May 31, 2024 14:56
c02098b
to
81a6632
Compare
legobeat
force-pushed
the
e2e-decrease-retries
branch
from
May 31, 2024 17:33
81a6632
to
354b9de
Compare
benjisclowder
added
the
release-12.0.0
Issue or pull request that will be included in release 12.0.0
label
Jun 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-CI
e2e-test
End to end test for the MetaMask extension
release-12.0.0
Issue or pull request that will be included in release 12.0.0
team-security
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reduces:
Non-E2E CI jobs have their existing retry count unchanged.
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist