Cherry-pick: feat: Add animation on the Smart Transaction status page (#24389) into v11.15.3 #24397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Add animation on the Smart Transaction status page. We reused the animation from Smart Swaps. ## **Related issues** Fixes: ## **Manual testing steps** 1. Turn on Smart Transactions in Advanced Settings 2. Use the Sepolia test network 3. Submit a Send transaction 4. You will see the animation on the Smart Transaction status page ## **Screenshots/Recordings** ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.15.3 #24397 +/- ##
=================================================
Coverage 67.54% 67.54%
=================================================
Files 1247 1247
Lines 48945 48945
Branches 12788 12788
=================================================
Hits 33059 33059
Misses 15886 15886 ☔ View full report in Codecov by Sentry. |
Builds ready [c5335d9]
Page Load Metrics (1197 ± 599 ms)
|
metamaskbot
added
the
release-11.15.3
|
No release label on PR. Adding release label release-11.15.3 on PR, as PR was cherry-picked in branch 11.15.3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick f0ac9c0, (#24389) into v11.15.3