Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add animation on the Smart Transaction status page #24389

Merged
merged 1 commit into from
May 7, 2024

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented May 6, 2024

Description

Add animation on the Smart Transaction status page. We reused the animation from Smart Swaps.

Related issues

Fixes:

Manual testing steps

  1. Turn on Smart Transactions in Advanced Settings
  2. Use the Sepolia test network
  3. Submit a Send transaction
  4. You will see the animation on the Smart Transaction status page

Screenshots/Recordings

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dan437 dan437 requested a review from a team as a code owner May 6, 2024 14:33
Copy link
Contributor

github-actions bot commented May 6, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dan437 dan437 added the team-transactions Transactions team label May 6, 2024
@dan437 dan437 changed the title Add animation on the Smart Transaction status page feat: Add animation on the Smart Transaction status page May 6, 2024
background-position: 0 0;

&--top {
width: 1634px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a future PR:
Where do these constants come from? Should we use computed values or constants?
cc @georgewrmarshall from DS team.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tag @dbrans! I tend to think arbitrary values in styles are code smells, but sometimes they are necessary. It would be great to see a screencast of these changes in the PR description so I can review without having to checkout the branch and locate where these changes are implemented @dan437 🙏

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This width is twice the size of the transaction-background-top.svg image (817px) and I believe it was used in the past to make the animation work properly. We just reused the same code for animation from Smart Swaps as a short term solution. We will be replacing it with a long term solution once it's designed.

Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.34%. Comparing base (d27a233) to head (1e16638).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #24389      +/-   ##
===========================================
- Coverage    67.37%   67.34%   -0.03%     
===========================================
  Files         1278     1282       +4     
  Lines        49881    50065     +184     
  Branches     12944    12986      +42     
===========================================
+ Hits         33605    33716     +111     
- Misses       16276    16349      +73     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [1e16638]
Page Load Metrics (185 ± 252 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint5611278199
domContentLoaded86515157
load452471185525252
domInteractive86515157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 358 Bytes (0.01%)
  • common: 0 Bytes (0.00%)

@dbrans dbrans merged commit f0ac9c0 into develop May 7, 2024
79 of 80 checks passed
@dbrans dbrans deleted the stx-status-page-animation branch May 7, 2024 01:12
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.15.3 Issue or pull request that will be included in release 11.15.3 and removed release-11.18.0 labels May 7, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.15.3 on PR. Adding release label release-11.15.3 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.15.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.15.3 Issue or pull request that will be included in release 11.15.3 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants