Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version v11.13.3 #23891

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Version v11.13.3 #23891

merged 2 commits into from
Apr 8, 2024

Conversation

zone-live
Copy link
Contributor

Description

An MMI release, no conflicts.

Adds missing SENTRY_MMI_DSN to builds.yml.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

zone-live and others added 2 commits April 8, 2024 15:00
## **Description**

Adds MMI sentry dsn variable that is required in builds.yml

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@zone-live zone-live added the team-mmi PRs from the MMI team label Apr 8, 2024
@zone-live zone-live requested a review from a team as a code owner April 8, 2024 14:04
Copy link
Contributor

github-actions bot commented Apr 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live requested a review from danjm April 8, 2024 14:07
@metamaskbot metamaskbot added the release-11.13.3 Issue or pull request that will be included in release 11.13.3 label Apr 8, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [94c345f]
Page Load Metrics (485 ± 380 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint762641184722
domContentLoaded118328189
load632121485791380
domInteractive118328189

@danjm danjm merged commit 0aaffd1 into master Apr 8, 2024
69 of 71 checks passed
@danjm danjm deleted the Version-v11.13.3 branch April 8, 2024 20:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.13.3 Issue or pull request that will be included in release 11.13.3 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants