Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version v11.12.4 #23616

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Version v11.12.4 #23616

merged 4 commits into from
Mar 20, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Mar 20, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 20, 2024
@danjm danjm changed the base branch from develop to master March 20, 2024 19:46
@danjm danjm force-pushed the Version-v11.12.4 branch from 0411c99 to a76ae4a Compare March 20, 2024 20:21
@bergeron @danjm
fix: revert aggregated fiat balance on home page (#23614) (#23617)
177ec59 
cherry picking #23614

Not a clean cherry pick, handled conflicts in 3 files.

---------

Co-authored-by: Dan J Miller <[email protected]>
@danjm danjm marked this pull request as ready for review March 20, 2024 20:37
@danjm danjm requested a review from a team as a code owner March 20, 2024 20:37
bergeron
bergeron previously approved these changes Mar 20, 2024
View reviewed changes
@metamaskbot metamaskbot added the release-11.12.4 Issue or pull request that will be included in release 11.12.4 label Mar 20, 2024
bergeron
bergeron previously approved these changes Mar 20, 2024
View reviewed changes
@metamaskbot metamaskbot mentioned this pull request Mar 20, 2024
Merged
bergeron and others added 2 commits March 20, 2024 19:42
@bergeron @danjm
fix: test for v11.12.4 release (#23619)
6b1e892 
Fix test for v11.12.4 release
@bowensanders @danjm
fix: fix typo in snap install rejected metric (#23618)
cda3bdd 
## **Description**

Fixes a typo in the name for the `SnapInstallRejected` MetaMetrics
event.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/23618?quickstart=1)
@danjm danjm force-pushed the Version-v11.12.4 branch from c3f6d36 to cda3bdd Compare March 20, 2024 22:12
@metamaskbot
Copy link
Collaborator

Builds ready [cda3bdd]
Page Load Metrics (1865 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1144171928440
domContentLoaded96929199
load15602099186515575
domInteractive96929199

@danjm danjm merged commit 6d3dc01 into master Mar 20, 2024
68 of 70 checks passed
@danjm danjm deleted the Version-v11.12.4 branch March 20, 2024 22:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bergeron bergeron bergeron left review comments

Assignees
No one assigned
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-11.12.4 Issue or pull request that will be included in release 11.12.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danjm @metamaskbot @bergeron @bowensanders