-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: MMI adds fallback property when environment key doesnt exist #23494
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [1d36487]
Page Load Metrics (1193 ± 399 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23494 +/- ##
========================================
Coverage 68.71% 68.71%
========================================
Files 1129 1129
Lines 43675 43676 +1
Branches 11672 11673 +1
========================================
+ Hits 30009 30010 +1
Misses 13666 13666 ☔ View full report in Codecov by Sentry. |
Builds ready [38e047e]
Page Load Metrics (1075 ± 433 ms)
Bundle size diffs
|
Missing release label release-11.12.3 on PR. Adding release label release-11.12.3 on PR and removing other release labels(release-11.14.0), as PR was cherry-picked in branch 11.12.3. |
Description
We need to add the
service
key value as a fallback for when the custodian doesn't send anenvironment
property.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist