Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: MMI adds fallback property when environment key doesnt exist #23494

Merged
merged 2 commits into from
Mar 15, 2024

Conversation

zone-live
Copy link
Contributor

Description

We need to add the service key value as a fallback for when the custodian doesn't send an environment property.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner March 14, 2024 16:09
@zone-live zone-live requested a review from albertolive March 14, 2024 16:09
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added the team-mmi PRs from the MMI team label Mar 14, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [1d36487]
Page Load Metrics (1193 ± 399 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint741951243718
domContentLoaded107733209
load6020261193830399
domInteractive107733209
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.71%. Comparing base (72e8512) to head (38e047e).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23494   +/-   ##
========================================
  Coverage    68.71%   68.71%           
========================================
  Files         1129     1129           
  Lines        43675    43676    +1     
  Branches     11672    11673    +1     
========================================
+ Hits         30009    30010    +1     
  Misses       13666    13666           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [38e047e]
Page Load Metrics (1075 ± 433 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint663421275627
domContentLoaded117133168
load5222941075902433
domInteractive117133168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 466e7ec into develop Mar 15, 2024
67 checks passed
@zone-live zone-live deleted the MMI-4787-environment-property-fallback branch March 15, 2024 10:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2024
@metamaskbot metamaskbot added release-11.14.0 Issue or pull request that will be included in release 11.14.0 release-11.12.3 Issue or pull request that will be included in release 11.12.3 and removed release-11.14.0 Issue or pull request that will be included in release 11.14.0 labels Mar 15, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.12.3 on PR. Adding release label release-11.12.3 on PR and removing other release labels(release-11.14.0), as PR was cherry-picked in branch 11.12.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.12.3 Issue or pull request that will be included in release 11.12.3 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants