Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update validate-conventional-commits.yml #23455

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Mar 13, 2024

Currently we are validating the PR title of PRs made against release branches and master, but this breaks our release branching and PR processes. For release candidate PRs, we don't want a conventional commit title. This PR updates the conventional commit validation workflow. As a result of this PR, we now follow the same approach as mobile https://github.com/MetaMask/metamask-mobile/blob/ef5febdc0964884352486b91b2cfe0e11f3fda29/.github/workflows/pr-title-linter.yml

@danjm danjm requested a review from a team as a code owner March 13, 2024 11:17
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Mar 13, 2024
@DDDDDanica DDDDDanica added team-extension-platform and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (669022c) to head (86a3dbb).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23455   +/-   ##
========================================
  Coverage    68.73%   68.73%           
========================================
  Files         1124     1124           
  Lines        43617    43617           
  Branches     11674    11674           
========================================
  Hits         29976    29976           
  Misses       13641    13641           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [86a3dbb]
Page Load Metrics (1076 ± 468 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982451473417
domContentLoaded116828147
load8123921076975468
domInteractive116828147
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danjm danjm merged commit 5a5805f into develop Mar 13, 2024
71 of 73 checks passed
@danjm danjm deleted the update-validate-conventional-commits branch March 13, 2024 11:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@metamaskbot metamaskbot added release-11.14.0 Issue or pull request that will be included in release 11.14.0 release-11.12.0 Issue or pull request that will be included in release 11.12.0 and removed release-11.14.0 Issue or pull request that will be included in release 11.14.0 labels Mar 13, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.12.0 on PR. Adding release label release-11.12.0 on PR and removing other release labels(release-11.14.0), as PR was cherry-picked in branch 11.12.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants