-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Update validate-conventional-commits.yml #23455
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23455 +/- ##
========================================
Coverage 68.73% 68.73%
========================================
Files 1124 1124
Lines 43617 43617
Branches 11674 11674
========================================
Hits 29976 29976
Misses 13641 13641 ☔ View full report in Codecov by Sentry. |
Builds ready [86a3dbb]
Page Load Metrics (1076 ± 468 ms)
Bundle size diffs
|
Missing release label release-11.12.0 on PR. Adding release label release-11.12.0 on PR and removing other release labels(release-11.14.0), as PR was cherry-picked in branch 11.12.0. |
Currently we are validating the PR title of PRs made against release branches and master, but this breaks our release branching and PR processes. For release candidate PRs, we don't want a conventional commit title. This PR updates the conventional commit validation workflow. As a result of this PR, we now follow the same approach as mobile https://github.com/MetaMask/metamask-mobile/blob/ef5febdc0964884352486b91b2cfe0e11f3fda29/.github/workflows/pr-title-linter.yml