fix: Token Cell Setting and Token Symbol in cell (#23348) #23355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## **Description** Fixing an issue where the Preferred Currency setting appeared to be flipped, and a different issue where the token symbol was being shown as USD rather than ETH. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/23348?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Open Extension 2. Make note of which preferred currency setting is currently on 3. Verify that if Fiat is toggled on, Fiat appears on top inside the first Token Cell component, and symbols are correct. 4. Verify that if ETH is toggled on, ETH appears on top inside the first Token Cell Component, and symbols are correct. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> Fiat Toggled ON: <img width="355" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/cc165f35-e1f8-4e2c-ac15-5bb123c880b0"> <img width="355" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/ec054145-c958-4ec7-aa48-30a17c809c7d"> ETH Toggled ON: <img width="358" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/2a2fb134-1e1d-4ed6-bacd-2c4e720bd1fa"> <img width="358" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/1bd4b01f-051e-4d9c-b66f-62a3f1ec920e"> ### **After** <!-- [screenshots/recordings] --> Fiat Toggled ON: <img width="355" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/6e401774-1e2d-4c42-ad23-b3ee614d37bf"> <img width="355" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/ad06b397-9a5c-4cf3-a356-b6a71fff0b2d"> ETH Toggled ON: <img width="358" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/7d220ccf-089e-4f43-84c5-6fcdaf2a6811"> <img width="358" alt="image" src="https://github.com/MetaMask/metamask-extension/assets/10986371/deb66faf-3288-4819-a41c-99c4e2a4c067"> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
](https://codespaces.new/MetaMask/metamask-extension/pull/23348?quickstart=1){kind=link}
metamaskbot
added
the
release-11.11.2
|
No release label on PR. Adding release label release-11.11.2 on PR, as PR was cherry-picked in branch 11.11.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were no merge conflicts when picking these commits
Fixing an issue where the Preferred Currency setting appeared to be flipped, and a different issue where the token symbol was being shown as USD rather than ETH.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
Fiat Toggled ON:
ETH Toggled ON:
After
Fiat Toggled ON:
ETH Toggled ON:
Pre-merge author checklist
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist