Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update PPOM dependency to 1.4.2 #23219

Merged
merged 2 commits into from
Feb 28, 2024
Merged

feat: update PPOM dependency to 1.4.2 #23219

merged 2 commits into from
Feb 28, 2024

Conversation

jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 28, 2024

Description

Update PPOM dependency to version 1.4.2.

Related issues

Fixes: MetaMask/MetaMask-planning#2150

Manual testing steps

  1. Go to test dapp
  2. Submit a couple of benign / malicious transactions
  3. Ensure PPOM validations work as expected

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 28, 2024
@jpuri jpuri requested a review from a team as a code owner February 28, 2024 05:46
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri
Copy link
Contributor Author

jpuri commented Feb 28, 2024

@metamaskbot update-policies

@jpuri jpuri changed the title Update PPOM dependency to 1.4.2 feat: update PPOM dependency to 1.4.2 Feb 28, 2024
@metamaskbot
Copy link
Collaborator

No policy changes

Copy link

socket-security bot commented Feb 28, 2024

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@blockaid/[email protected]

View full report↗︎

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.60%. Comparing base (688e06f) to head (af36105).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #23219   +/-   ##
========================================
  Coverage    68.60%   68.60%           
========================================
  Files         1098     1098           
  Lines        43319    43319           
  Branches     11557    11557           
========================================
  Hits         29715    29715           
  Misses       13604    13604           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [af36105]
Page Load Metrics (915 ± 493 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint612531214823
domContentLoaded10100342612
load4824859151026493
domInteractive10100342612
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit 02cbc94 into develop Feb 28, 2024
67 checks passed
@jpuri jpuri deleted the ppom_update_1.4.2 branch February 28, 2024 15:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 28, 2024
@metamaskbot metamaskbot added the release-11.13.0 Issue or pull request that will be included in release 11.13.0 label Feb 28, 2024
@metamaskbot metamaskbot added release-11.11.2 Issue or pull request that will be included in release 11.11.2 and removed release-11.13.0 Issue or pull request that will be included in release 11.13.0 labels Mar 6, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.11.2 on PR. Adding release label release-11.11.2 on PR and removing other release labels(release-11.13.0), as PR was cherry-picked in branch 11.11.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.11.2 Issue or pull request that will be included in release 11.11.2 team-confirmations-secure-ux-PR PRs from the confirmations team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants