Version 11.7.1 #22305

DDDDDanica · 2023-12-15T18:37:14Z

Description

Related issues

Fixes:

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2023-12-15T18:37:25Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

DDDDDanica · 2023-12-15T21:51:27Z

@metamaskbot update-policies

metamaskbot · 2023-12-15T21:52:59Z

Policy update failed. You can review the logs or retry the policy update here

socket-security · 2023-12-18T14:09:47Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
@metamask/keyring-controller	8.1.0...8.0.3	None	`+5/-1`	387 kB	metamaskbot
@zxing/browser	0.1.4...0.0.10	None	`+1/-1`	15.9 MB	odahcam
@zxing/library	0.20.0...0.8.0	None	`+2/-0`	16.6 MB	odahcam

socket-security · 2023-12-18T14:09:50Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

danjm · 2023-12-18T16:00:11Z

@SocketSecurity ignore-all

There was a bump for library @zxing.js #19225 to audit the package, however, there're breaking changes from API in this library. We will have a temporary fix by reverting the upgrade and ignore the audit changes, but we will have a follow up PR to have proper fix and add e2e test to backup. We also include the copy update as [requested](#22160 (comment)).  Fixes: #22160 1. Go to send 2. Click scanner icon beside address 3. provide a QR code to scan   https://github.com/MetaMask/metamask-extension/assets/12678455/b792c931-4213-4e85-b376-c6cf7f5ef01a - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: MetaMask Bot <[email protected]>

## **Description** When a user adds a chain from a dapp, they will see warnings that the currency symbol is incorrect, even though it is correct. Part of the problem was that the `pendingConfirmation` variable inside of `fetchSafeChainsList` was undefined when it should not be. I guess it closed over the original value or something like that? I didn't verify. This PR corrects it by explictly passing the updated `pendingConfirmations` variable to `fetchSafeChainList` The other problem was that `useAlertState` was calling `getTemplateAlerts` twice, without resetting the alert state. On the first call, alerts were being set in state because the request to chainId.network had not yet resolved. This PR fixes it by ensuring that that `useAlertState` does not call `getTemplateAlerts` before the fetch to chainId.network has resolved (when this confrimation type is an add ethereum chain approval) ## **Related issues** An example of the problem can be seen by going to https://chainlist.org/?search=cro and adding Cronos Mainnet to metamask, only to see warnings that the currency symbol is incorrect even though it is correct. ![Screenshot from 2023-12-15 18-26-51](https://github.com/MetaMask/metamask-extension/assets/7499938/80e299d4-1545-4a38-981f-8b1eafc0b3dc) ## **Manual testing steps** 1. Go to https://chainlist.org/?search=cro 2. Add Cronos mainnet to metamask 3. The confirmation window should open with an add ethereum chain confirmation. There should be no warnings 4. Reject the confirmation 5. Open the dev console and paste the below code, and press enter. The confirmation window should open with an add ethereum chain confirmation. There should be warnings about the currency symbol 6. Reject the confirmation 7. Modify the below code so that `"symbol": "cra",` becomes `"symbol": "cro",`, paste it in the dev console and press enter. There should be no warnings in the new confirmation window ``` await window.ethereum.request({ "method": "wallet_addEthereumChain", "params": [ { "blockExplorerUrls": [ "https://blockscout.com/poa/xdai/" ], "nativeCurrency": { "name": "CRO", "symbol": "cra", "decimals": 18 }, "rpcUrls": [ "https://evm.cronos.org", null ], "chainId": "0x19", "chainName": "Cronos Mainnet" } ] }); ``` ### **Before** https://github.com/MetaMask/metamask-extension/assets/7499938/d6f738be-8e4a-4618-8703-c2d94df9c8a7 ### **After** https://github.com/MetaMask/metamask-extension/assets/7499938/c3ab5cf6-ac73-4ad3-b7b3-fd49910c0311  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Pedro Figueiredo <[email protected]>

We want a ChainID: Ticker Map for future validation on some of our more commonly used networks. This PR adds that mapping constant, changes Optimism's "OP" ticker to "ETH" and fixes a resulting unit test failure.  Fixes: [#1708 ](MetaMask/MetaMask-planning#1708)    - [X] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've clearly explained what problem this PR is solving and how it is solved. - [X] I've linked related issues - [X] I've included manual testing steps - [X] I've included screenshots/recordings if applicable - [X] I’ve included tests if applicable - [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [X] I’ve properly set the pull request status: - [X] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Dan J Miller <[email protected]>

…based backup (#22307)' into v11.7.0 During the backup flow, we should prompt a user for a password. This provides extra friction during a security sensitive step. 1. Build, install and onboard 2. Make sure to back up your seed phrase during onboarding. Onboarding should work as normal 3. Once you get to the home screen, replace `home.html` in the url browsers url bar with `home.html#onboarding/secure-your-wallet/?isFromReminder=true` and press enter 4. Click "Secure my wallet" 5. You should then be prompted to enter your password. 6. After entering your password, you should be able to proceed as normal If you repeat those steps but click cancel when being prompted to enter your password, you should be taken to the home screen. If you repeat those steps, but on step 2 don't back up your seed phrase, the remaining steps should work as described above. https://github.com/MetaMask/metamask-extension/assets/7499938/ac8b5dfb-ca7b-4622-95b8-07db5405abfe - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Pedro Figueiredo <[email protected]>

…#22326) (#22328) ## **Description** Cryptocompare reported a spike in API requests. This is the result of incorrectly starting CurrencyRateController polling on MetaMask extension background startup. This PR fixes the issue by removing the logic that was starting CurrencyRateController polling in the constructor. ## **Related issues** Fixes: #21549 ## **Manual testing steps** 1. Open network debug on background.html 2. Restart extension 3. No cryptocompare requests should be seen 4. Open wallet UI 5. One cryptocompare request should be seen 6. Wait 3mins 7. Another cryptocompare request should be seen 8. Close UI 9. Wait 3mins 10. No additional cryptocompare requests should be seen ## **Screenshots/Recordings**  ### **Before** Note the requests made before the UI is open, but that they are stopped after UI is opened then closed for the first time. https://github.com/MetaMask/metamask-extension/assets/918701/c66eabd0-363b-467a-87e3-5628daa95395 ### **After** https://github.com/MetaMask/metamask-extension/assets/918701/3676fa9d-4b6f-4c4d-941d-eac7b0ab7194 ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained what problem this PR is solving and how it is solved. - [x] I've linked related issues - [x] I've included manual testing steps - [x] I've included screenshots/recordings if applicable - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [x] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. ## **Description**  ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings**  ### **Before**  ### **After**  ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2023-12-18T21:42:08Z

Builds ready [e9507de]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (623 ± 301 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	177	131	22	11
		domContentLoaded	79	166	118	26	12
		load	92	1683	623	626	301
		domInteractive	79	166	118	26	12

DDDDDanica requested a review from a team as a code owner December 15, 2023 18:37

DDDDDanica temporarily deployed to desktop December 15, 2023 18:37 — with GitHub Actions Inactive

DDDDDanica changed the title ~~v11.7.1~~ Version 11.7.1 Dec 15, 2023

DDDDDanica requested review from a team as code owners December 15, 2023 21:32

DDDDDanica temporarily deployed to desktop December 15, 2023 21:32 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 18, 2023 13:02 — with GitHub Actions Inactive

DDDDDanica force-pushed the Version-v11.7.1 branch from a469292 to 307e7c0 Compare December 18, 2023 13:04

DDDDDanica temporarily deployed to desktop December 18, 2023 13:05 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 18, 2023 13:06 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 18, 2023 13:07 — with GitHub Actions Inactive

danjm force-pushed the Version-v11.7.1 branch from 2e2867b to 86d35ec Compare December 18, 2023 14:03

danjm temporarily deployed to desktop December 18, 2023 14:03 — with GitHub Actions Inactive

danjm force-pushed the Version-v11.7.1 branch from 86d35ec to 29fb5dc Compare December 18, 2023 15:07

danjm temporarily deployed to desktop December 18, 2023 15:08 — with GitHub Actions Inactive

DDDDDanica force-pushed the Version-v11.7.1 branch from 29fb5dc to 92545de Compare December 18, 2023 17:39

DDDDDanica temporarily deployed to desktop December 18, 2023 17:39 — with GitHub Actions Inactive

danjm force-pushed the Version-v11.7.1 branch from 92545de to 1d83e1f Compare December 18, 2023 18:38

danjm temporarily deployed to desktop December 18, 2023 18:38 — with GitHub Actions Inactive

DDDDDanica and others added 5 commits December 18, 2023 15:09

v11.7.1

8b61628

danjm force-pushed the Version-v11.7.1 branch from 1d83e1f to bb181f4 Compare December 18, 2023 18:39

danjm temporarily deployed to desktop December 18, 2023 18:39 — with GitHub Actions Inactive

danjm temporarily deployed to desktop December 18, 2023 19:34 — with GitHub Actions Inactive

DDDDDanica temporarily deployed to desktop December 18, 2023 19:46 — with GitHub Actions Inactive

Update changelog for v11.7.1

e9507de

danjm force-pushed the Version-v11.7.1 branch from 1140d29 to e9507de Compare December 18, 2023 20:20

danjm temporarily deployed to desktop December 18, 2023 20:20 — with GitHub Actions Inactive

danjm approved these changes Dec 18, 2023

View reviewed changes

danjm merged commit 06b7b4b into master Dec 18, 2023
68 of 70 checks passed

danjm deleted the Version-v11.7.1 branch December 18, 2023 22:10

github-actions bot locked and limited conversation to collaborators Dec 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Version 11.7.1 #22305

Version 11.7.1 #22305

DDDDDanica commented Dec 15, 2023

github-actions bot commented Dec 15, 2023

DDDDDanica commented Dec 15, 2023

metamaskbot commented Dec 15, 2023

socket-security bot commented Dec 18, 2023 •

edited

Loading

socket-security bot commented Dec 18, 2023 •

edited

Loading

danjm commented Dec 18, 2023

metamaskbot commented Dec 18, 2023

Version 11.7.1 #22305

Version 11.7.1 #22305

Conversation

DDDDDanica commented Dec 15, 2023

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 15, 2023

DDDDDanica commented Dec 15, 2023

metamaskbot commented Dec 15, 2023

socket-security bot commented Dec 18, 2023 • edited Loading

socket-security bot commented Dec 18, 2023 • edited Loading

Next steps

danjm commented Dec 18, 2023

metamaskbot commented Dec 18, 2023

socket-security bot commented Dec 18, 2023 •

edited

Loading

socket-security bot commented Dec 18, 2023 •

edited

Loading