Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ledger legacy transactions #22136

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix Ledger legacy transactions #22136

merged 2 commits into from
Dec 4, 2023

Conversation

mikesposito
Copy link
Member

Description

This PR sets the minimum @metamask/eth-ledger-bridge-keyring version to 2.0.1, which includes a bugfix for broken legacy transactions on all Ledger devices.

Related issues

Fixes: #22118

Manual testing steps

  1. Connect a Ledger account to MM
  2. Send a legacy transaction from the test dapp

Screenshots/Recordings

Before

Screenshot 2023-11-29 at 6 20 37 PM

After

The above error should not be thrown

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@mikesposito mikesposito requested a review from a team as a code owner December 4, 2023 10:41
Copy link
Contributor

github-actions bot commented Dec 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [9dabb56]
Page Load Metrics (1260 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92155109168
domContentLoaded9451973
load10001552126013766
domInteractive9441973
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 20 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@mikesposito mikesposito merged commit 76f7035 into develop Dec 4, 2023
10 checks passed
@mikesposito mikesposito deleted the fix/ledger-rlp-encoding branch December 4, 2023 12:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2023
@metamaskbot metamaskbot added the release-11.8.0 Issue or pull request that will be included in release 11.8.0 label Dec 4, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [d247d5a]
Page Load Metrics (1440 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint901941272713
domContentLoaded96724157
load102218331440241116
domInteractive96724157
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 20 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gauthierpetetin gauthierpetetin added release-11.7.0 Issue or pull request that will be included in release 11.7.0 and removed release-11.8.0 Issue or pull request that will be included in release 11.8.0 labels Jan 2, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.7.0 on PR. Adding release label release-11.7.0 on PR and removing other release labels(release-11.8.0), as PR was added to branch 11.7.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.7.0 Issue or pull request that will be included in release 11.7.0 team-wallet-framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to Send legacy transaction with Ledger
5 participants