-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ledger legacy transactions #22136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
legobeat
approved these changes
Dec 4, 2023
danjm
approved these changes
Dec 4, 2023
Builds ready [9dabb56]
Page Load Metrics (1260 ± 66 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-11.8.0
Issue or pull request that will be included in release 11.8.0
label
Dec 4, 2023
Builds ready [d247d5a]
Page Load Metrics (1440 ± 116 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
gauthierpetetin
added
release-11.7.0
Issue or pull request that will be included in release 11.7.0
and removed
release-11.8.0
Issue or pull request that will be included in release 11.8.0
labels
Jan 2, 2024
Missing release label release-11.7.0 on PR. Adding release label release-11.7.0 on PR and removing other release labels(release-11.8.0), as PR was added to branch 11.7.0 when release was cut. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR sets the minimum
@metamask/eth-ledger-bridge-keyring
version to2.0.1
, which includes a bugfix for broken legacy transactions on all Ledger devices.Related issues
Fixes: #22118
Manual testing steps
Screenshots/Recordings
Before
After
The above error should not be thrown
Pre-merge author checklist
Pre-merge reviewer checklist