-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move token detection to top of assets #20932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergeron
added
the
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
label
Sep 18, 2023
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
… brian/token-detection-above-the-fold
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20932 +/- ##
===========================================
- Coverage 68.25% 68.25% -0.00%
===========================================
Files 1006 1006
Lines 40184 40183 -1
Branches 10742 10741 -1
===========================================
- Hits 27424 27423 -1
Misses 12760 12760
☔ View full report in Codecov by Sentry. |
Builds ready [b9f14c7]
Page Load Metrics (1626 ± 45 ms)
Bundle size diffs
|
HowardBraham
approved these changes
Sep 19, 2023
sahar-fehri
approved these changes
Sep 20, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Moves the prompt for importing detected tokens from the bottom to the top of the assets view. So that users can see it without scrolling to the bottom.
Implements https://consensyssoftware.atlassian.net/browse/MMASSETS-24
Screenshots/Screencaps
Before
After
Manual Testing Steps
Send an ERC-20 token to the account and verify the import prompt appears at the top.
Pre-merge author checklist
Pre-merge reviewer checklist