Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move token detection to top of assets #20932

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

bergeron
Copy link
Contributor

Explanation

Moves the prompt for importing detected tokens from the bottom to the top of the assets view. So that users can see it without scrolling to the bottom.

Implements https://consensyssoftware.atlassian.net/browse/MMASSETS-24

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

Send an ERC-20 token to the account and verify the import prompt appears at the top.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@bergeron bergeron requested a review from a team as a code owner September 18, 2023 13:58
@bergeron bergeron added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Sep 18, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 25.00% and no project coverage change.

Comparison is base (a3a99aa) 68.25% compared to head (b9f14c7) 68.25%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20932      +/-   ##
===========================================
- Coverage    68.25%   68.25%   -0.00%     
===========================================
  Files         1006     1006              
  Lines        40184    40183       -1     
  Branches     10742    10741       -1     
===========================================
- Hits         27424    27423       -1     
  Misses       12760    12760              
Files Changed Coverage Δ
ui/components/app/asset-list/asset-list.js 75.00% <25.00%> (-0.76%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [b9f14c7]
Page Load Metrics (1626 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1101961412010
domContentLoaded1484181616269445
load1484181616269445
domInteractive1484181616269445
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -4 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@bergeron bergeron merged commit 9f7ccfc into develop Sep 20, 2023
@bergeron bergeron deleted the brian/token-detection-above-the-fold branch September 20, 2023 20:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants