Fix #20910 - Turn off ENS resolution if IPFS is turned off #20915

darkwing · 2023-09-15T19:01:32Z

Explanation

Fixes [Bug]: Show ENS domain in address bar toggle defaults #20910

When a user turns off the "IPFS gateway" settings, the "Show ENS domains in address bar" setting should also be disabled.

Screenshots/Screencaps

Screen.Recording.2023-09-15.at.1.54.22.PM.mov

Manual Testing Steps

Open Settings > Security
Turn off the "IPFS gateway" toggle
The "Show ENS domains in address bar" should also toggle off

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-09-15T19:01:46Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2023-09-15T21:15:52Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (3741079) 68.25% compared to head (8fb0471) 68.24%.
Report is 9 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #20915      +/-   ##
===========================================
- Coverage    68.25%   68.24%   -0.01%     
===========================================
  Files         1006     1006              
  Lines        40190    40198       +8     
  Branches     10744    10750       +6     
===========================================
  Hits         27430    27430              
- Misses       12760    12768       +8

Files Changed	Coverage Δ
app/scripts/lib/ens-ipfs/setup.js	`0.00% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-09-15T21:25:40Z

Builds ready [efc1f39]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1557 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	165	130	17	8
		domContentLoaded	1375	1933	1555	147	71
		load	1375	1957	1557	150	72
		domInteractive	1375	1933	1555	147	71

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 47 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-09-18T17:07:32Z

Builds ready [874d480]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1685 ± 93 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	114	187	139	19	9
		domContentLoaded	1487	2313	1685	193	93
		load	1487	2313	1685	193	93
		domInteractive	1487	2313	1685	193	93

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 47 Bytes (0.00%)
common: 0 Bytes (0.00%)

darkwing · 2023-09-18T20:53:04Z

@PeterYinusa What's the reason for DO-NOT-MERGE?

metamaskbot · 2023-09-18T21:27:40Z

Builds ready [4bcd17f]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1628 ± 94 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	110	194	141	17	8
		domContentLoaded	1453	2212	1628	195	94
		load	1453	2212	1628	195	94
		domInteractive	1453	2212	1628	195	94

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 47 Bytes (0.00%)
common: 0 Bytes (0.00%)

legobeat · 2023-09-18T22:05:34Z

@darkwing See discussion in #20910

metamaskbot · 2023-09-21T14:54:57Z

Builds ready [8fb0471]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1578 ± 35 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	123	160	140	12	6
		domContentLoaded	1482	1755	1578	72	35
		load	1482	1755	1578	72	35
		domInteractive	1482	1755	1578	72	35

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 51 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 0 Bytes (0.00%)

darkwing requested a review from a team as a code owner September 15, 2023 19:01

darkwing added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Sep 15, 2023

NidhiKJha previously approved these changes Sep 18, 2023

View reviewed changes

PeterYinusa added the DO-NOT-MERGE Pull requests that should not be merged label Sep 18, 2023

PeterYinusa mentioned this pull request Sep 18, 2023

[Bug]: Show ENS domain in address bar toggle defaults #20910

Closed

darkwing added 3 commits September 20, 2023 09:05

Fix #20910 - Turn off ENS resolution if IPFS is turned off

403ee04

Updated WIP

a549e60

Implement conditions for ENS and IPFS settings

5ce9b46

darkwing dismissed NidhiKJha’s stale review via 5ce9b46 September 20, 2023 19:37

darkwing force-pushed the 20910-ipfs-settings branch from 4bcd17f to 5ce9b46 Compare September 20, 2023 19:37

darkwing added 2 commits September 20, 2023 14:59

Remove initial fix

135ea69

Fix e2es

8fb0471

darkwing force-pushed the 20910-ipfs-settings branch from ff04005 to 8fb0471 Compare September 20, 2023 21:41

danjm added release-blocker This bug is blocking the next release release-11.1.0 Issue or pull request that will be included in release 11.1.0 labels Sep 21, 2023

PeterYinusa removed the DO-NOT-MERGE Pull requests that should not be merged label Sep 21, 2023

DDDDDanica approved these changes Sep 21, 2023

View reviewed changes

kevinghim added the team-extension-client label Sep 21, 2023

kevinghim assigned darkwing Sep 21, 2023

pedronfigueiredo approved these changes Sep 21, 2023

View reviewed changes

darkwing merged commit a0349a6 into develop Sep 21, 2023
11 of 14 checks passed

darkwing deleted the 20910-ipfs-settings branch September 21, 2023 16:37

github-actions bot locked and limited conversation to collaborators Sep 21, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 21, 2023

danjm removed the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #20910 - Turn off ENS resolution if IPFS is turned off #20915

Fix #20910 - Turn off ENS resolution if IPFS is turned off #20915

darkwing commented Sep 15, 2023

github-actions bot commented Sep 15, 2023

codecov bot commented Sep 15, 2023 •

edited

Loading

metamaskbot commented Sep 15, 2023

metamaskbot commented Sep 18, 2023

darkwing commented Sep 18, 2023

metamaskbot commented Sep 18, 2023

legobeat commented Sep 18, 2023

metamaskbot commented Sep 21, 2023

Fix #20910 - Turn off ENS resolution if IPFS is turned off #20915

Fix #20910 - Turn off ENS resolution if IPFS is turned off #20915

Conversation

darkwing commented Sep 15, 2023

Explanation

Screenshots/Screencaps

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 15, 2023

codecov bot commented Sep 15, 2023 • edited Loading

Codecov Report

metamaskbot commented Sep 15, 2023

metamaskbot commented Sep 18, 2023

darkwing commented Sep 18, 2023

metamaskbot commented Sep 18, 2023

legobeat commented Sep 18, 2023

metamaskbot commented Sep 21, 2023

codecov bot commented Sep 15, 2023 •

edited

Loading