-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Snaps: Only display Notification in Global Menu if enabled snap uses that permission #20913
Conversation
…ses that permission
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
14dead7
to
a4c4a0b
Compare
a4c4a0b
to
5b0fd41
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20913 +/- ##
===========================================
- Coverage 68.26% 68.25% -0.01%
===========================================
Files 1002 1002
Lines 40133 40140 +7
Branches 10742 10744 +2
===========================================
+ Hits 27395 27397 +2
- Misses 12738 12743 +5
☔ View full report in Codecov by Sentry. |
Builds ready [3af635d]
Page Load Metrics (1583 ± 36 ms)
Bundle size diffs
|
getPermissionSubjects, | ||
(snaps, subjects) => { | ||
return Object.values(snaps).filter( | ||
({ id }) => subjects[id]?.permissions.snap_notify, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't seen destructuring in the filter callbackFn args before. Nice
Explanation
The Snaps™ team has asked that we only display the "Notifications" global menu item if the user has a snap™ that uses that permission.
Reference: #20911
Screenshots/Screencaps
With a Snap™ enabled that uses
snap_notify
permissionWith no Snap™ enabled that uses
snap_notify
permissionManual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.