Add verifiedOnBlockchain property to transaction meta #20890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vinistevam
force-pushed
the
1100-add-verifiedOnBlockchain-property-transaction-meta
branch
from
765d855 to
e1e9827
Compare
vinistevam
added
the
team-confirmations-system
|
Both scenarios work as expected.
s_eth.movSending tokens: tst_s.mov |
| @@ -963,6 +963,8 @@ export default class TransactionController extends EventEmitter { | |||
| if (blockTimestamp) { | |||
| txMeta.blockTimestamp = blockTimestamp; | |||
| } | |||
| // transaction verified on the blockchain | |||
There was a problem hiding this comment.
Minor, but is this comment adding much additional detail?
matthewwalsh0
previously approved these changes
Sep 16, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20890 +/- ##
===========================================
+ Coverage 68.26% 68.27% +0.01%
===========================================
Files 1002 1003 +1
Lines 40133 40150 +17
Branches 10742 10745 +3
===========================================
+ Hits 27395 27411 +16
- Misses 12738 12739 +1
☔ View full report in Codecov by Sentry. |
Builds ready [84ddc22]
Page Load Metrics (1651 ± 79 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
matthewwalsh0
approved these changes
Sep 18, 2023
Builds ready [9a249b0]
Page Load Metrics (1568 ± 38 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
OGPoyraz
approved these changes
Sep 19, 2023
Builds ready [045aa32]
Page Load Metrics (1650 ± 41 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
vinistevam
deleted the
1100-add-verifiedOnBlockchain-property-transaction-meta
branch
metamaskbot
added
the
release-11.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to add
verifiedOnBlockchainproperty to transaction metadata as part of the ongoing effort to align the extension transaction controller with the controller in the core repo.For context, the core
TransactionControlleruses averifiedOnBlockchainproperty to indicate whether a transaction has completed the verification process and therefore the status is now fixed and no further checks will be performed.If the transaction receipt indicates the transaction failed, the
verifiedOnBlockchainis still set totrueto prevent further processing.Changes
verifiedOnBlockchainto transaction metadata.PendingTransactionTracker.Manual Testing Steps
Scenario 1
Scenario 2
Both scenarios should be successfully completed, as usual, with no functional changes.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.