Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use name component in signature requests #20831

Merged
merged 24 commits into from
Sep 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
b2113da
Add name and combo components
matthewwalsh0 Sep 8, 2023
a339366
Revert bad merge changes
matthewwalsh0 Sep 8, 2023
482f703
Use released name controller
matthewwalsh0 Sep 8, 2023
8dae5db
Update snapshots
matthewwalsh0 Sep 8, 2023
c754e18
Update Lavamoat policies
matthewwalsh0 Sep 8, 2023
dd4f2a5
Fix linting
matthewwalsh0 Sep 8, 2023
caf7a5f
Use name component in signature data
matthewwalsh0 Sep 11, 2023
5633a35
Add E2E test
matthewwalsh0 Sep 12, 2023
8c22ca7
Update proposed names in name component
matthewwalsh0 Sep 13, 2023
3c18c96
Merge branch 'feat/name-component' into feat/signature-names-flask
matthewwalsh0 Sep 13, 2023
3f4e045
Mock name provider requests in E2E test
matthewwalsh0 Sep 13, 2023
daf6902
Fix unit tests
matthewwalsh0 Sep 13, 2023
1a7c7ff
Merge branch 'feat/name-component' into feat/signature-names-flask
matthewwalsh0 Sep 13, 2023
c255458
Fix unit tests
matthewwalsh0 Sep 13, 2023
70a9c48
Move form combo field to UI directory
matthewwalsh0 Sep 13, 2023
c5fdaca
Add E2E test for V3 signatures
matthewwalsh0 Sep 13, 2023
e57454b
Merge branch 'feat/name-component' into feat/signature-names-flask
matthewwalsh0 Sep 13, 2023
f192a3c
Revert unnecessary change
matthewwalsh0 Sep 13, 2023
cbe4188
Fix CSS import
matthewwalsh0 Sep 13, 2023
6534103
Merge branch 'feat/name-component' into feat/signature-names-flask
matthewwalsh0 Sep 13, 2023
e6a95b0
Merge branch 'develop' into feat/signature-names-flask
matthewwalsh0 Sep 18, 2023
5d70f93
Merge branch 'develop' into feat/signature-names-flask
matthewwalsh0 Sep 18, 2023
c93917c
Use property rather than custom style
matthewwalsh0 Sep 18, 2023
4f56098
Merge branch 'develop' into feat/signature-names-flask
matthewwalsh0 Sep 19, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert unnecessary change
  • Loading branch information
matthewwalsh0 committed Sep 13, 2023
commit f192a3c02d2833ed6e8687a45a82041d042d150d
2 changes: 1 addition & 1 deletion app/scripts/metamask-controller.js
Original file line number Diff line number Diff line change
@@ -1012,7 +1012,7 @@ export default class MetamaskController extends EventEmitter {
});

const allowLocalSnaps = process.env.ALLOW_LOCAL_SNAPS;
const requireAllowlist = false;
const requireAllowlist = process.env.REQUIRE_SNAPS_ALLOWLIST;

this.snapController = new SnapController({
environmentEndowmentPermissions: Object.values(EndowmentPermissions),