Remove keyringMemStore from DetectTokensController
#20728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mikesposito
force-pushed
the
refactor/detect-tokens-keyring-controller
branch
from
5bb117f to
1af59a7
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #20728 +/- ##
========================================
Coverage 68.17% 68.17%
========================================
Files 998 998
Lines 39966 39968 +2
Branches 10686 10684 -2
========================================
+ Hits 27243 27246 +3
+ Misses 12723 12722 -1
☔ View full report in Codecov by Sentry. |
Builds ready [a572703]
Page Load Metrics (1608 ± 54 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
commented
Sep 5, 2023
Comment on lines
-19
to
-24
| function buildMessenger() { | ||
| return new ControllerMessenger().getRestricted({ | ||
| name: 'DetectTokensController', | ||
| allowedEvents: ['NetworkController:stateChange'], | ||
| }); | ||
| } |
There was a problem hiding this comment.
This has been substituted with getRestrictedMessenger which uses the messenger instance available in the higher scope, as it helps registering a mock handler for the KeyringController:getState action.
mikesposito
force-pushed
the
refactor/detect-tokens-keyring-controller
branch
3 times, most recently
from
aa5875a to
2e4fdb9
Compare
Builds ready [2e4fdb9]
Page Load Metrics (1714 ± 70 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
force-pushed
the
refactor/detect-tokens-keyring-controller
branch
from
2e4fdb9 to
1fd7479
Compare
Builds ready [1fd7479]
Page Load Metrics (1514 ± 33 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
force-pushed
the
refactor/detect-tokens-keyring-controller
branch
from
747a221 to
af31acf
Compare
Builds ready [af31acf]
Page Load Metrics (1570 ± 55 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
force-pushed
the
refactor/detect-tokens-keyring-controller
branch
from
af31acf to
c3ca98c
Compare
metamaskbot
added
the
release-11.3.0
Builds ready [c3ca98c]
Page Load Metrics (1675 ± 114 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR removes the
keyringMemStoreconstructor parameter, as we can now subscribe toKeyringControllerevents through the messenger. Instead of listening on all Keyring state changes, we can listen to:lockand:unlockevents.@metamask/eth-keyring-controllerfromDetectTokensController#20723Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.