Use QRKeyring from KeyringController
#20502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
mikesposito
changed the title
mikesposito
changed the title
QRKeyring from KeyringController
mikesposito
commented
Aug 17, 2023
mikesposito
force-pushed
the
refactor/use-qr-keyring
branch
from
3a6f05d to
6334e1b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #20502 +/- ##
===========================================
- Coverage 68.39% 68.35% -0.05%
===========================================
Files 1007 1007
Lines 40252 40260 +8
Branches 10764 10770 +6
===========================================
- Hits 27529 27516 -13
- Misses 12723 12744 +21
☔ View full report in Codecov by Sentry. |
Builds ready [6334e1b]
Page Load Metrics (1627 ± 49 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
mikesposito
force-pushed
the
refactor/use-qr-keyring
branch
2 times, most recently
from
0263a6c to
6334e1b
Compare
Builds ready [6334e1b]
Page Load Metrics (1705 ± 67 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
cryptodev-2s
force-pushed
the
refactor/use-qr-keyring
branch
from
6334e1b to
2516be6
Compare
Builds ready [2516be6]
Page Load Metrics (1696 ± 163 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
cryptodev-2s
force-pushed
the
refactor/use-qr-keyring
branch
2 times, most recently
from
f200d6e to
1176bd0
Compare
Builds ready [1176bd0]
Page Load Metrics (1864 ± 104 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
cryptodev-2s
force-pushed
the
refactor/use-qr-keyring
branch
from
1176bd0 to
8b8e5e9
Compare
mikesposito
force-pushed
the
refactor/use-qr-keyring
branch
4 times, most recently
from
0071617 to
ccaef57
Compare
Builds ready [ccaef57]
Page Load Metrics (1686 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [ccaef57]
Page Load Metrics (1686 ± 73 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mikesposito
force-pushed
the
refactor/use-qr-keyring
branch
from
d0e137c to
83765a0
Compare
Builds ready [83765a0]
Page Load Metrics (1682 ± 84 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: @metamask/[email protected], @metamask/[email protected] |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
mikesposito
force-pushed
the
refactor/use-qr-keyring
branch
2 times, most recently
from
971bb2b to
01c50cf
Compare
|
@metamaskbot update-policies |
|
Policies updated |
mikesposito
commented
Sep 26, 2023
Comment on lines
+873
to
+889
| allowedActions: [ | ||
| 'KeyringController:getState', | ||
| 'KeyringController:signMessage', | ||
| 'KeyringController:signPersonalMessage', | ||
| 'KeyringController:signTypedMessage', | ||
| 'KeyringController:decryptMessage', | ||
| 'KeyringController:getEncryptionPublicKey', | ||
| 'KeyringController:getKeyringsByType', | ||
| 'KeyringController:getKeyringForAccount', | ||
| 'KeyringController:getAccounts', | ||
| ], | ||
| allowedEvents: [ | ||
| 'KeyringController:accountRemoved', | ||
| 'KeyringController:lock', | ||
| 'KeyringController:stateChange', | ||
| 'KeyringController:lock', | ||
| 'KeyringController:unlock', | ||
| 'KeyringController:accountRemoved', | ||
| 'KeyringController:qrKeyringStateChange', |
There was a problem hiding this comment.
These are related to @metamask/keyring-controller update v7.4 -> v8.0
Builds ready [dfa7991]
Page Load Metrics (1504 ± 241 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This is our package |
mikesposito
force-pushed
the
refactor/use-qr-keyring
branch
from
dfa7991 to
7bdc1b0
Compare
metamaskbot
added
the
release-11.3.0
Builds ready [7bdc1b0]
Page Load Metrics (969 ± 339 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
With this PR the extension starts to use the
QRKeyringprovided byKeyringController, instead of declaring and managing it directly in the client.Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.