Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document onboarding test scenarios #20262

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

PeterYinusa
Copy link
Contributor

@PeterYinusa PeterYinusa commented Jul 28, 2023

Explanation

Fixes #18919
Review Importing a wallet

Fixes #18918
Review Creating a wallet

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa marked this pull request as ready for review July 28, 2023 14:56
@PeterYinusa PeterYinusa requested a review from a team as a code owner July 28, 2023 14:56
@PeterYinusa PeterYinusa self-assigned this Jul 28, 2023
@PeterYinusa PeterYinusa changed the title [skip e2e] document onboarding flows Document onboarding test scenarios Jul 28, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [3ba44b6]
Page Load Metrics (1512 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint100147123115
domContentLoaded1390170815127938
load1390170815127938
domInteractive1390170815127938

@PeterYinusa PeterYinusa merged commit c741222 into develop Jul 28, 2023
@PeterYinusa PeterYinusa deleted the document-onboarding-flows branch July 28, 2023 16:28
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 28, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding: Importing a wallet Onboarding: Creating a wallet
5 participants