Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue generating the pipeline #20231

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fixed issue generating the pipeline #20231

merged 1 commit into from
Jul 27, 2023

Conversation

albertolive
Copy link
Contributor

@albertolive albertolive commented Jul 27, 2023

Explanation

Fixed prep-build-mmi error in the pipeline here.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@albertolive albertolive requested a review from a team as a code owner July 27, 2023 11:12
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [4fd69f4]
Page Load Metrics (2324 ± 308 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint11141026510651
domContentLoaded139529822323641308
load139529822324642308
domInteractive139529822323641308
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -5 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@albertolive albertolive merged commit 68f5c57 into develop Jul 27, 2023
@albertolive albertolive deleted the bugifx/mmi-build branch July 27, 2023 12:36
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 27, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants