Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Adds mmi build step #20207

Merged
merged 4 commits into from
Jul 27, 2023
Merged

[MMI] Adds mmi build step #20207

merged 4 commits into from
Jul 27, 2023

Conversation

zone-live
Copy link
Contributor

@zone-live zone-live commented Jul 26, 2023

This adds the prep-build-mmi step, it's necessary and convenient for us to have the artefact generated, it also validates that any change introduced breaks the build.
CircleCI run

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@zone-live zone-live requested review from a team, kumavis and brad-decker as code owners July 26, 2023 13:33
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #20207 (90d5c2e) into develop (d262acb) will not change coverage.
Report is 14 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20207   +/-   ##
========================================
  Coverage    68.70%   68.70%           
========================================
  Files          986      986           
  Lines        37817    37817           
  Branches     10116    10116           
========================================
  Hits         25979    25979           
  Misses       11838    11838           

@albertolive albertolive merged commit 72b274d into develop Jul 27, 2023
@albertolive albertolive deleted the MMI-3564-adds-mmi-build-step branch July 27, 2023 08:08
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 27, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants