Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Fix TextColor value casing #20133

Merged
merged 2 commits into from
Jul 24, 2023
Merged

UX: Fix TextColor value casing #20133

merged 2 commits into from
Jul 24, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

Fixes casing of wrong TypeScript constant value

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 21, 2023 19:42
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [c26d900]
Page Load Metrics (1502 ± 44 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99172124178
domContentLoaded1378180115029144
load1378180215029144
domInteractive1378180115029144
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -2 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Merging #20133 (c26d900) into develop (e1722d7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20133   +/-   ##
========================================
  Coverage    69.35%   69.35%           
========================================
  Files          986      986           
  Lines        37265    37265           
  Branches     10002    10002           
========================================
  Hits         25843    25843           
  Misses       11422    11422           
Impacted Files Coverage Δ
...s/app/approve-content-card/approve-content-card.js 75.00% <ø> (ø)
...dger-instruction-field/ledger-instruction-field.js 58.90% <ø> (ø)

@darkwing darkwing merged commit d5dbdfa into develop Jul 24, 2023
@darkwing darkwing deleted the textcolor-case branch July 24, 2023 18:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 24, 2023
@kevinghim kevinghim added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 25, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants