Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the networkController instead of preferencesController #20127

Merged
merged 4 commits into from
Jul 24, 2023

Conversation

zone-live
Copy link
Contributor

The values we want are located in the networkController now.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@zone-live zone-live requested a review from a team as a code owner July 21, 2023 15:41
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live changed the title listen for the networkController instead of preferencesController Use the networkController instead of preferencesController Jul 21, 2023
@zone-live zone-live requested a review from mcmire July 21, 2023 16:10
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One suggestion I have is that if there is not already one in place, you may want to add a unit test for your controller so you know that this creates the change that you expect. It's non-blocking though.

@codecov

This comment was marked as outdated.

@metamaskbot
Copy link
Collaborator

Builds ready [88daef7]
Page Load Metrics (1627 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1112201373014
domContentLoaded14511953162714570
load14511953162714570
domInteractive14511953162714570
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@albertolive albertolive merged commit 13faeea into develop Jul 24, 2023
@albertolive albertolive deleted the MMI-fix-networks-value branch July 24, 2023 09:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 24, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 24, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants