feat(874): add footer to connect Hardware wallet and style refactor #20121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
DDDDDanica
commented
Jul 21, 2023
| @@ -263,7 +263,7 @@ AccountList.propTypes = { | |||
| onUnlockAccounts: PropTypes.func, | |||
| onCancel: PropTypes.func, | |||
| onAccountRestriction: PropTypes.func, | |||
| hdPaths: PropTypes.array.isRequired, | |||
| hdPaths: PropTypes.object.isRequired, | |||
DDDDDanica
commented
Jul 21, 2023
| @@ -14,7 +14,7 @@ const render = () => { | |||
| }); | |||
|
|
|||
| const props = { | |||
| selectedPath: TREZOR_HD_PATHS[0].path, | |||
| selectedPath: TREZOR_HD_PATHS[0].value, | |||
Builds ready [9d2d8e7]
Page Load Metrics (1392 ± 23 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov Report
@@ Coverage Diff @@
## develop #20121 +/- ##
===========================================
+ Coverage 69.37% 69.38% +0.01%
===========================================
Files 987 987
Lines 37265 37267 +2
Branches 10006 10006
===========================================
+ Hits 25852 25856 +4
+ Misses 11413 11411 -2
|
DDDDDanica
changed the title
Builds ready [57926fc]
Page Load Metrics (1477 ± 28 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
This looks good to me @DDDDDanica, @kevinghim for future planning, it would be good to allocate some time to enhance this specific section, to make it seamlessly integrate with the rest of the UI, looks a bit messy now: |
vthomas13
approved these changes
Jul 21, 2023
pedronfigueiredo
approved these changes
Jul 24, 2023
metamaskbot
added
the
release-10.36.0
Gudahtt
added
release-11.1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Screenshots/Screencaps
Before
Hardware wallet onboarding
Hardware wallet onboarding with no supported browser
After
Hardware wallet onboarding
Hardware wallet onboarding with no supported browser
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.