Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unused deprecated Text component #20119

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Jul 20, 2023

Explanation

Finally part of the updating deprecated Text paths in the extension is to remove the deprecated component as it is no longer in use.

Screenshots/Screencaps

No results for text/deprecated

Screenshot 2023-07-20 at 10 51 58 AM

Manual Testing Steps

  • Pull this branch
  • Search part of the import path which would return a result if the deprecated component was used text/deprecated
  • See no results

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall self-assigned this Jul 20, 2023
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 20, 2023
@georgewrmarshall georgewrmarshall marked this pull request as ready for review July 20, 2023 20:30
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner July 20, 2023 20:30
@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #20119 (d5fd4cf) into develop (733391a) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #20119      +/-   ##
===========================================
- Coverage    69.38%   69.36%   -0.02%     
===========================================
  Files          987      985       -2     
  Lines        37267    37240      -27     
  Branches     10008     9995      -13     
===========================================
- Hits         25854    25829      -25     
+ Misses       11413    11411       -2     

@metamaskbot
Copy link
Collaborator

Builds ready [d5fd4cf]
Page Load Metrics (1526 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1062031312613
domContentLoaded13741908152613565
load13741909152613565
domInteractive13741908152613565
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

@garrettbear garrettbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP ☠️ Text js version

@georgewrmarshall georgewrmarshall merged commit c9ce85b into develop Jul 21, 2023
@georgewrmarshall georgewrmarshall deleted the part/19986/remove-deprecated-text branch July 21, 2023 15:44
@github-actions github-actions bot locked and limited conversation to collaborators Jul 21, 2023
@metamaskbot metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 21, 2023
@Gudahtt Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update deprecated Text import paths
5 participants